-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp-netcore]: Adding http response details in api_docs and making example snippet compilable #3128
Merged
wing328
merged 7 commits into
OpenAPITools:master
from
saigiridhar21:csharpdotnetcore-headers-caseinsensitive
Jun 21, 2019
Merged
[csharp-netcore]: Adding http response details in api_docs and making example snippet compilable #3128
wing328
merged 7 commits into
OpenAPITools:master
from
saigiridhar21:csharpdotnetcore-headers-caseinsensitive
Jun 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator into csharpdotnetcore-headers-caseinsensitive
saigiridhar21
changed the title
[csharp-netcore]: Adding http response details in api
[csharp-netcore]: Adding http response details in api_docs and making example snippet compilable
Jun 9, 2019
saigiridhar21
force-pushed
the
csharpdotnetcore-headers-caseinsensitive
branch
from
June 10, 2019 01:25
a41b376
to
aafd5eb
Compare
wing328
reviewed
Jun 21, 2019
@@ -128,12 +129,14 @@ namespace Example | |||
{{#summary}} | |||
// {{{.}}} | |||
{{/summary}} | |||
{{#returnType}}{{{.}}} result = {{/returnType}}apiInstance.{{{operationId}}}({{#allParams}}{{paramName}}{{#hasMore}}, {{/hasMore}}{{/allParams}});{{#returnType}} | |||
{{#returnType}}{{{returnType}}} result = {{/returnType}}apiInstance.{{{operationId}}}({{#allParams}}{{paramName}}{{#hasMore}}, {{/hasMore}}{{/allParams}});{{#returnType}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saigiridhar21 FYI. the {{{.}}} is default to the value of the mustache tag
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 24, 2019
* master: (25 commits) Add #send to ruby reserved word list (OpenAPITools#3146) Merge java8 doc for spring (OpenAPITools#3122) added api key authentication to aspnetcore 2.1 (OpenAPITools#3089) Add "yue9944882" to Perl technical committee (OpenAPITools#3194) [csharp-netcore]: Adding http response details in api_docs and making example snippet compilable (OpenAPITools#3128) generate travis configuration (OpenAPITools#3193) Perl: Basic bearer auth support (OpenAPITools#3192) [R] feat(r) : Alternate PR for serialization fixes along with WithHttpInfo method enhancement (OpenAPITools#3099) improve release checkout script (OpenAPITools#3184) Prepare 4.0.3-SNAPSHOT (OpenAPITools#3185) 4.0.2 release (OpenAPITools#3181) Fix rubocop obsolescence (OpenAPITools#3175) Add Fuse to the company list (OpenAPITools#3164) Idiomatic Rust returns for Error conversions (OpenAPITools#2812) Add API timeout handling (OpenAPITools#3078) Import inner items for map (OpenAPITools#3123) update core team in pom.xml (OpenAPITools#3126) [gradle] Document consuming via gradle plugin portal (OpenAPITools#3125) Bump up babel-cli version to fix security alert (OpenAPITools#3121) [C++] [cpprestsdk] Add examples and test for cpprestsdk (OpenAPITools#3109) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Closes:#3133
@mandrean (2017/08), @jimschubert (2017/09)