Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic testing list is slow on demo environment #1184

Closed
jborozco opened this issue Jul 2, 2024 · 3 comments
Closed

Atomic testing list is slow on demo environment #1184

jborozco opened this issue Jul 2, 2024 · 3 comments
Assignees
@savacano28
Labels
bug use for describing something not working as expected solved The issue has been solved
Milestone
Release 1.9.0

Comments

@jborozco
Copy link

jborozco commented Jul 2, 2024

Description

It takes too long, 5-10 sec to display the list of atomic testings

Reproducible Steps

Go to https://demo.obas.filigran.io/admin/atomic_testings
@jborozco jborozco added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Jul 2, 2024
@jborozco jborozco added this to the Bugs backlog milestone Jul 2, 2024
@jborozco jborozco mentioned this issue Jul 2, 2024
Closed
@Christian-DONGMO Christian-DONGMO self-assigned this Jul 8, 2024
@RomuDeuxfois RomuDeuxfois linked a pull request Jul 22, 2024 that will close this issue
[Frontend | Backend] Atomic testing list is slow on demo environment #1211
Closed
5 tasks
@savacano28 savacano28 self-assigned this Jul 26, 2024
@savacano28 savacano28 removed their assignment Aug 21, 2024
@RomuDeuxfois RomuDeuxfois self-assigned this Aug 23, 2024
@RomuDeuxfois RomuDeuxfois mentioned this issue Aug 26, 2024
Merged
RomuDeuxfois added a commit that referenced this issue Aug 28, 2024
@RomuDeuxfois @guillaumejparis
[frontend] Remove double fetch (#1184)
2224367 
Co-authored-by: Guillaume Paris <guillaume.paris@filigran.io>
@RomuDeuxfois
Copy link
Member

I tested different things to try improving performance on this list:

  • view on DB -> verify usefull for simple bean, but not for bean with post computation on some properties
  • batching -> no effect on this case
  • merging current requests -> difficult to manage and maintain

RomuDeuxfois added a commit that referenced this issue Sep 5, 2024
@RomuDeuxfois
[backend] Add new indexes on join (#1184)
54ee361
@RomuDeuxfois RomuDeuxfois mentioned this issue Sep 5, 2024
Merged
RomuDeuxfois added a commit that referenced this issue Sep 5, 2024
@RomuDeuxfois
[backend] Add new indexes on join (#1184)
f108f24
RomuDeuxfois added a commit that referenced this issue Sep 6, 2024
@RomuDeuxfois
[backend] Add new indexes on join (#1184)
a89a911
RomuDeuxfois added a commit that referenced this issue Sep 9, 2024
@RomuDeuxfois
[backend] Atomic testing list is slow on demo environment (#1184)
cb7c0fd
@RomuDeuxfois RomuDeuxfois added the solved The issue has been solved label Sep 9, 2024
@RomuDeuxfois RomuDeuxfois reopened this Sep 13, 2024
@RomuDeuxfois RomuDeuxfois removed the solved The issue has been solved label Sep 13, 2024
@savacano28 savacano28 self-assigned this Sep 25, 2024
@RomuDeuxfois
Copy link
Member

Maybe it's fixed by the performance improvment we are working on in the 1.8.0 milestone.
We need to retest it after the release.

@savacano28
Copy link
Contributor

PR to improve latenvy atomic testings: #1733

@RomuDeuxfois RomuDeuxfois added the solved The issue has been solved label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savacano28 savacano28

Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
Milestone
Release 1.9.0
Development

Successfully merging a pull request may close this issue.

[Frontend | Backend] Atomic testing list is slow on demo environment OpenBAS-Platform/openbas
6 participants
@SamuelHassine @savacano28 @guillaumejparis @jborozco @RomuDeuxfois @Christian-DONGMO