Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve latency on atomicTestings #1733

Merged
merged 10 commits into from
Oct 29, 2024
Merged

[backend] Improve latency on atomicTestings #1733

merged 10 commits into from
Oct 29, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Oct 23, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 23, 2024
@savacano28 savacano28 self-assigned this Oct 23, 2024
@savacano28 savacano28 changed the title [backend] Improve latency on atomicTesting page [backend] Improve latency on atomicTestings Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 32.20%. Comparing base (37e2a33) to head (a08e44e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../java/io/openbas/service/AtomicTestingService.java 0.00% 44 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1733      +/-   ##
============================================
- Coverage     32.24%   32.20%   -0.05%     
  Complexity     1609     1609              
============================================
  Files           561      561              
  Lines         16755    16776      +21     
  Branches        963      964       +1     
============================================
  Hits           5403     5403              
- Misses        11108    11129      +21     
  Partials        244      244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the bugfix/1719 branch 2 times, most recently from a96bd05 to 0a9fd2b Compare October 25, 2024 13:24
@savacano28 savacano28 force-pushed the bugfix/1719 branch 2 times, most recently from 6b63b67 to fa916fe Compare October 28, 2024 09:39
@savacano28 savacano28 marked this pull request as ready for review October 28, 2024 09:39
@savacano28 savacano28 force-pushed the bugfix/1719 branch 2 times, most recently from 0a861c0 to a15f8f7 Compare October 29, 2024 10:08
@savacano28 savacano28 merged commit 5ff61ad into master Oct 29, 2024
7 checks passed
@savacano28 savacano28 deleted the bugfix/1719 branch October 30, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve latency on Atomic Testings
2 participants