Hotfix/stock screener - Stock Screener Fixes (#4674)

* stock screener fixes

* improves error message, this is a FinViz preset

* removes non-screener functions from screener menu

* ruff

* removes tests for removed non-screener functions

* updates tests

* black

* ruff

* adds s&p 500 sector presets

* updates Terminal intro guide for stock screener

* Update screener.md

Updates guide with screenshots.

* Update screener.md

spelling

* updates SDK Intro Guide for Stock Screener

* pylint disable=too-many-lines --> disable=C0302

---------

Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>

openbb_terminal/core/sdk/controllers/stocks_sdk_controller.py

@@ -310,9 +310,6 @@ def screener(self):
         """Stocks Screener Submodule
 
         Attributes:
-            `arktrades`: Gets a dataframe of ARK trades for ticker\n
-            `historical`: View historical price of stocks that meet preset\n
-            `historical_chart`: View historical price of stocks that meet preset\n
             `screener_data`: Screener Overview\n
             `screener_data_chart`: Screener one of the following: overview, valuation, financial, ownership, performance, technical.\n
         """

openbb_terminal/core/sdk/models/stocks_sdk_model.py

@@ -538,9 +538,6 @@ class StocksScreener(Category):
     """Screener Module.
 
     Attributes:
-        `arktrades`: Gets a dataframe of ARK trades for ticker\n
-        `historical`: View historical price of stocks that meet preset\n
-        `historical_chart`: View historical price of stocks that meet preset\n
         `screener_data`: Screener Overview\n
         `screener_data_chart`: Screener one of the following: overview, valuation, financial, ownership, performance, technical.\n
     """
@@ -549,9 +546,6 @@ class StocksScreener(Category):
 
     def __init__(self):
         super().__init__()
-        self.arktrades = lib.stocks_screener_ark_model.get_ark_trades_by_ticker
-        self.historical = lib.stocks_screener_yahoofinance_model.historical
-        self.historical_chart = lib.stocks_screener_yahoofinance_view.historical
         self.screener_data = lib.stocks_screener_finviz_model.get_screener_data
         self.screener_data_chart = lib.stocks_screener_finviz_view.screener
 

openbb_terminal/core/sdk/sdk_init.py

@@ -401,10 +401,6 @@
 from openbb_terminal.stocks.screener import (
     finviz_model as stocks_screener_finviz_model,
     finviz_view as stocks_screener_finviz_view,
-    yahoofinance_model as stocks_screener_yahoofinance_model,
-    yahoofinance_view as stocks_screener_yahoofinance_view,
-    ark_model as stocks_screener_ark_model,
-    ark_view as stocks_screener_ark_view,
 )
 
 # Stocks - Technical Analysis

openbb_terminal/core/sdk/trail_map.csv

@@ -532,8 +532,6 @@ stocks.qa.capm,stocks_qa_factors_model.capm_information,
 stocks.qa.fama_raw,stocks_qa_factors_model.get_fama_raw,
 stocks.qa.historical_5,stocks_qa_factors_model.get_historical_5,
 stocks.quote,stocks_model.get_quote,
-stocks.screener.arktrades,stocks_screener_ark_model.get_ark_trades_by_ticker,
-stocks.screener.historical,stocks_screener_yahoofinance_model.historical,stocks_screener_yahoofinance_view.historical
 stocks.screener.screener_data,stocks_screener_finviz_model.get_screener_data,stocks_screener_finviz_view.screener
 stocks.search,stocks_helper.search,
 stocks.ta.recom,stocks_ta_tradingview_model.get_tradingview_recommendation,stocks_ta_tradingview_view.print_recommendation

openbb_terminal/miscellaneous/i18n/en.yml

@@ -250,14 +250,12 @@ en:
   stocks/scr/view: view available presets (defaults and customs)
   stocks/scr/set: set one of the available presets
   stocks/scr/_preset: Preset
-  stocks/scr/historical: view historical price
   stocks/scr/overview: overview (e.g. Sector, Industry, Market Cap, Volume)
   stocks/scr/valuation: valuation (e.g. P/E, PEG, P/S, P/B, EPS this Y)
   stocks/scr/financial: financial (e.g. Dividend, ROA, ROE, ROI, Earnings)
   stocks/scr/ownership: ownership (e.g. Float, Insider Own, Short Ratio)
   stocks/scr/performance: performance (e.g. Perf Week, Perf YTD, Volatility M)
   stocks/scr/technical: technical (e.g. Beta, SMA50, 52W Low, RSI, Change)
-  stocks/scr/arktrades: get ARK trades for a chosen ticker
   stocks/scr/_screened_tickers: Last screened tickers
   stocks/scr/ca: take these to comparison analysis menu
   stocks/ins/view: view available presets

openbb_terminal/miscellaneous/stocks/screener/djia_components.ini

@@ -0,0 +1,13 @@
+# Author of preset: OpenBB
+# Description: Filter for the Dow Jones Industrial Average components.
+
+[General]
+
+[Descriptive]
+
+Index = DJIA
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sdk_guide_preset.ini

@@ -0,0 +1,16 @@
+# Author of preset: OpenBB
+# Description: SDK Demo Screener
+
+[General]
+Order = Market Cap.
+Signal = Major News
+
+[Descriptive]
+Average Volume = Over 500K
+Price = Over $5
+
+[Fundamental]
+Price/Free Cash Flow = Low (<15)
+
+[Technical]
+Beta = Under 0.5

openbb_terminal/miscellaneous/stocks/screener/sp500_basic_materials_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Basic Materials Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Basic Materials
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_communication_services_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Communication Services Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Communication Services
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_consumer_cyclical_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Consumer Cyclical Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Consumer Cyclical
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_consumer_defensive_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Consumer Defensive Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Consumer Defensive
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_energy_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Energy Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Energy
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_financial_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Financial Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Financial
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_healthcare_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Healthcare Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Healthcare
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_industrials_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Industrials Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Industrials
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_real_estate_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Real Estate Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Real Estate
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_technology_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Technology Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Technology
+
+[Fundamental]
+
+[Technical]
+

openbb_terminal/miscellaneous/stocks/screener/sp500_utilities_sector.ini

@@ -0,0 +1,14 @@
+# Author of preset: OpenBB
+# Description: Filter for the S&P 500 Utilities Sector components.
+
+[General]
+
+[Descriptive]
+
+Index = S&P 500
+Sector = Utilities
+
+[Fundamental]
+
+[Technical]
+