Hotfix/stock screener - Stock Screener Fixes #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
feat XL
Updates guide with screenshots.
spelling
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4674 +/- ##
==========================================
Coverage ? 57.56%
==========================================
Files ? 589
Lines ? 53830
Branches ? 0
==========================================
Hits ? 30989
Misses ? 22841
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
deeleeramone
changed the title
jmaslek
pushed a commit
that referenced
this pull request
Apr 13, 2023
* stock screener fixes * improves error message, this is a FinViz preset * removes non-screener functions from screener menu * ruff * removes tests for removed non-screener functions * updates tests * black * ruff * adds s&p 500 sector presets * updates Terminal intro guide for stock screener * Update screener.md Updates guide with screenshots. * Update screener.md spelling * updates SDK Intro Guide for Stock Screener * pylint disable=too-many-lines --> disable=C0302 --------- Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the stock screener, improves the default responses to work better with the new tables, and adds a new batch of presets.
Description
fixes #4570
closes #4180
Removes a hard-coded limit argument that overrode user input. Default setting now returns all results for the preset.
Removes non-screener functions from the screener menu (arktrades, historical).
Updates Terminal and SDK Intro Guides for the Stock Screener.
Adds a series of new presets for filtering the S&P 500 by Sector.
Summary of the change / bug fix.
Link # issue, if applicable.
Screenshot of the feature or the bug before/after fix, if applicable.
Relevant motivation and context.
How has this been tested?
The existing tests are still valid. Tests for
arktradesandhistoricalwere removed.Checklist:
feature/feature-nameorhotfix/hotfix-name.Others