Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/stock screener - Stock Screener Fixes #4674

Merged
merged 86 commits into from
Apr 8, 2023
Merged
Show file tree
Hide file tree
Changes from 82 commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
0a87277
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 20, 2023
b625974
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 21, 2023
9008778
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 21, 2023
791ea6d
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 23, 2023
744f078
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 24, 2023
5aef88b
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 28, 2023
02284c1
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 28, 2023
a02bc2b
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Feb 28, 2023
1ed5cfb
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 1, 2023
f6a124f
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 1, 2023
bd6ffa8
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 1, 2023
a133403
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 2, 2023
603e19e
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 2, 2023
b224059
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 2, 2023
a4352f4
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 2, 2023
d70a9e5
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 4, 2023
8d9f659
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 5, 2023
858e5f7
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 6, 2023
2ae2da1
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 6, 2023
8f652cc
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 7, 2023
7e8e4bb
merging
deeleeramone Mar 8, 2023
1221074
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 8, 2023
0fd550a
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 9, 2023
07eec02
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 9, 2023
a451acc
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 10, 2023
b47be20
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 10, 2023
7664e6c
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 11, 2023
5a865ce
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 12, 2023
cae7598
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 13, 2023
8680c53
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 14, 2023
acaa90d
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 14, 2023
18a216c
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 14, 2023
368b513
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 14, 2023
e12d97f
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 15, 2023
5ea3bd6
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 16, 2023
932cb5e
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 16, 2023
f492b17
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 16, 2023
41719fb
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 17, 2023
07781cb
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 17, 2023
fc1c6aa
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 17, 2023
8259038
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 17, 2023
fa059a1
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 17, 2023
5a599b3
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 20, 2023
b9e138c
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 20, 2023
6e766ca
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 21, 2023
8cc3359
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 21, 2023
ca00160
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 22, 2023
4d3c6ff
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 23, 2023
ca4e8d2
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 23, 2023
da117d5
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 24, 2023
fcdad58
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 24, 2023
27d7fc6
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 27, 2023
790b0fd
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 27, 2023
c72bed1
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 28, 2023
fb581f6
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 29, 2023
ad038b4
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 29, 2023
4bc3656
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 30, 2023
270a468
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 30, 2023
88063bf
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Mar 31, 2023
2d9bd42
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Apr 1, 2023
fd4496c
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Apr 3, 2023
a159d46
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Apr 3, 2023
515cd56
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
deeleeramone Apr 3, 2023
b717741
stock screener fixes
deeleeramone Apr 4, 2023
35c5e8e
Merge branch 'develop' into hotfix/stock_screener
deeleeramone Apr 4, 2023
4ce4f2f
improves error message, this is a FinViz preset
deeleeramone Apr 4, 2023
55b98d9
removes non-screener functions from screener menu
deeleeramone Apr 4, 2023
0216876
ruff
deeleeramone Apr 4, 2023
7d62856
Merge branch 'develop' into hotfix/stock_screener
deeleeramone Apr 4, 2023
7244349
removes tests for removed non-screener functions
deeleeramone Apr 4, 2023
f78d224
updates tests
deeleeramone Apr 4, 2023
7d0a0ae
black
deeleeramone Apr 4, 2023
88d1ed9
ruff
deeleeramone Apr 4, 2023
8a87e2f
Merge branch 'develop' into hotfix/stock_screener
deeleeramone Apr 4, 2023
2137ec7
Merge branch 'develop' into hotfix/stock_screener
deeleeramone Apr 4, 2023
ec2309f
adds s&p 500 sector presets
deeleeramone Apr 4, 2023
db8b101
updates Terminal intro guide for stock screener
deeleeramone Apr 4, 2023
f9787fb
Update screener.md
deeleeramone Apr 4, 2023
d27eda4
Update screener.md
deeleeramone Apr 4, 2023
063b93f
updates SDK Intro Guide for Stock Screener
deeleeramone Apr 4, 2023
87e9b5d
pylint disable=too-many-lines --> disable=C0302
deeleeramone Apr 4, 2023
43fda3b
merge conflict with pylint disable on stocks_helper.py
deeleeramone Apr 5, 2023
e7e063f
resolve merge conflict with pylint disable=C0302
deeleeramone Apr 6, 2023
f6cdbe0
resolves merge conflict for pylint too many lines again
deeleeramone Apr 7, 2023
7425062
Merge branch 'develop' into hotfix/stock_screener
deeleeramone Apr 7, 2023
eb5b048
Merge branch 'develop' into hotfix/stock_screener
hjoaquim Apr 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions openbb_terminal/core/sdk/controllers/stocks_sdk_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,6 @@ def screener(self):
"""Stocks Screener Submodule

Attributes:
`arktrades`: Gets a dataframe of ARK trades for ticker\n
`historical`: View historical price of stocks that meet preset\n
`historical_chart`: View historical price of stocks that meet preset\n
`screener_data`: Screener Overview\n
`screener_data_chart`: Screener one of the following: overview, valuation, financial, ownership, performance, technical.\n
"""
Expand Down
6 changes: 0 additions & 6 deletions openbb_terminal/core/sdk/models/stocks_sdk_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,6 @@ class StocksScreener(Category):
"""Screener Module.

Attributes:
`arktrades`: Gets a dataframe of ARK trades for ticker\n
`historical`: View historical price of stocks that meet preset\n
`historical_chart`: View historical price of stocks that meet preset\n
`screener_data`: Screener Overview\n
`screener_data_chart`: Screener one of the following: overview, valuation, financial, ownership, performance, technical.\n
"""
Expand All @@ -549,9 +546,6 @@ class StocksScreener(Category):

def __init__(self):
super().__init__()
self.arktrades = lib.stocks_screener_ark_model.get_ark_trades_by_ticker
self.historical = lib.stocks_screener_yahoofinance_model.historical
self.historical_chart = lib.stocks_screener_yahoofinance_view.historical
self.screener_data = lib.stocks_screener_finviz_model.get_screener_data
self.screener_data_chart = lib.stocks_screener_finviz_view.screener

Expand Down
4 changes: 0 additions & 4 deletions openbb_terminal/core/sdk/sdk_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,6 @@
from openbb_terminal.stocks.screener import (
finviz_model as stocks_screener_finviz_model,
finviz_view as stocks_screener_finviz_view,
yahoofinance_model as stocks_screener_yahoofinance_model,
yahoofinance_view as stocks_screener_yahoofinance_view,
ark_model as stocks_screener_ark_model,
ark_view as stocks_screener_ark_view,
)

# Stocks - Technical Analysis
Expand Down
2 changes: 0 additions & 2 deletions openbb_terminal/core/sdk/trail_map.csv
Original file line number Diff line number Diff line change
Expand Up @@ -532,8 +532,6 @@ stocks.qa.capm,stocks_qa_factors_model.capm_information,
stocks.qa.fama_raw,stocks_qa_factors_model.get_fama_raw,
stocks.qa.historical_5,stocks_qa_factors_model.get_historical_5,
stocks.quote,stocks_model.get_quote,
stocks.screener.arktrades,stocks_screener_ark_model.get_ark_trades_by_ticker,
stocks.screener.historical,stocks_screener_yahoofinance_model.historical,stocks_screener_yahoofinance_view.historical
stocks.screener.screener_data,stocks_screener_finviz_model.get_screener_data,stocks_screener_finviz_view.screener
stocks.search,stocks_helper.search,
stocks.ta.recom,stocks_ta_tradingview_model.get_tradingview_recommendation,stocks_ta_tradingview_view.print_recommendation
Expand Down
2 changes: 0 additions & 2 deletions openbb_terminal/miscellaneous/i18n/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,14 +249,12 @@ en:
stocks/scr/view: view available presets (defaults and customs)
stocks/scr/set: set one of the available presets
stocks/scr/_preset: Preset
stocks/scr/historical: view historical price
stocks/scr/overview: overview (e.g. Sector, Industry, Market Cap, Volume)
stocks/scr/valuation: valuation (e.g. P/E, PEG, P/S, P/B, EPS this Y)
stocks/scr/financial: financial (e.g. Dividend, ROA, ROE, ROI, Earnings)
stocks/scr/ownership: ownership (e.g. Float, Insider Own, Short Ratio)
stocks/scr/performance: performance (e.g. Perf Week, Perf YTD, Volatility M)
stocks/scr/technical: technical (e.g. Beta, SMA50, 52W Low, RSI, Change)
stocks/scr/arktrades: get ARK trades for a chosen ticker
stocks/scr/_screened_tickers: Last screened tickers
stocks/scr/ca: take these to comparison analysis menu
stocks/ins/view: view available presets
Expand Down
212 changes: 212 additions & 0 deletions openbb_terminal/miscellaneous/stocks/screener/all_parameters.txt

Large diffs are not rendered by default.

13 changes: 13 additions & 0 deletions openbb_terminal/miscellaneous/stocks/screener/djia_components.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Author of preset: OpenBB
# Description: Filter for the Dow Jones Industrial Average components.

[General]

[Descriptive]

Index = DJIA

[Fundamental]

[Technical]

16 changes: 16 additions & 0 deletions openbb_terminal/miscellaneous/stocks/screener/sdk_guide_preset.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Author of preset: OpenBB
# Description: SDK Demo Screener

[General]
Order = Market Cap.
Signal = Major News

[Descriptive]
Average Volume = Over 500K
Price = Over $5

[Fundamental]
Price/Free Cash Flow = Low (<15)

[Technical]
Beta = Under 0.5
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Basic Materials Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Basic Materials

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Communication Services Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Communication Services

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Consumer Cyclical Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Consumer Cyclical

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Consumer Defensive Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Consumer Defensive

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Energy Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Energy

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Financial Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Financial

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Healthcare Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Healthcare

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Industrials Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Industrials

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Real Estate Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Real Estate

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Technology Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Technology

[Fundamental]

[Technical]

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Author of preset: OpenBB
# Description: Filter for the S&P 500 Utilities Sector components.

[General]

[Descriptive]

Index = S&P 500
Sector = Utilities

[Fundamental]

[Technical]

70 changes: 0 additions & 70 deletions openbb_terminal/stocks/screener/ark_model.py

This file was deleted.

Loading