Run Limits Responses in Thread to Prevent Blocking Decom #1901
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
+ Coverage 79.42% 79.56% +0.14%
==========================================
Files 523 523
Lines 40926 41040 +114
==========================================
+ Hits 32506 32654 +148
+ Misses 8420 8386 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| self.logger.error(f"Called with old_state = {old_limits_state}, new_state = {item.limits.state}") | ||
| self.logger.error(repr(error)) | ||
| copied_packet = packet.deep_copy() | ||
| copied_item = packet.items[item.name] |
There was a problem hiding this comment.
This is just a reference right? Should it be a copy()?
There was a problem hiding this comment.
Because of the packet.deep_copy it is a reference to the correct new item.
| self.logger.error(f"{packet.target_name} {packet.packet_name} {item.name} Limits Response Exception!") | ||
| self.logger.error(f"Called with old_state = {old_limits_state}, new_state = {item.limits.state}") | ||
| self.logger.error(repr(error)) | ||
| copied_packet = packet.deep_copy() |
There was a problem hiding this comment.
Python already has deepcopy: https://docs.python.org/3/library/copy.html#copy.deepcopy. Should this just be packet.deepcopy?
There was a problem hiding this comment.
No. Its a "mostly" deep copy. At least in Ruby can't do a real deep copy because that would marshal Mutex which isn't allowed.
|
Would love for someone else to add new unit tests if necessary. ;) |
|
No description provided.