Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Microservice on any Thread Crash #1902

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Kill Microservice on any Thread Crash #1902

merged 6 commits into from
Feb 20, 2025

Conversation

ryanmelt
Copy link
Member

closes #286
closes #391

@ryanmelt ryanmelt requested a review from jmthomas February 16, 2025 04:40
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (2c13970) to head (52ca5e9).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...nc3/lib/openc3/microservices/decom_microservice.rb 40.00% 3 Missing ⚠️
...lib/openc3/microservices/interface_microservice.rb 50.00% 3 Missing ⚠️
...3/lib/openc3/microservices/reducer_microservice.rb 25.00% 3 Missing ⚠️
...c3/lib/openc3/microservices/router_microservice.rb 25.00% 3 Missing ⚠️
openc3/lib/openc3/microservices/microservice.rb 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1902      +/-   ##
==========================================
- Coverage   79.59%   79.59%   -0.01%     
==========================================
  Files         523      525       +2     
  Lines       41040    41155     +115     
==========================================
+ Hits        32667    32756      +89     
- Misses       8373     8399      +26     
Flag Coverage Δ
python 84.15% <ø> (-0.07%) ⬇️
ruby-api 48.51% <ø> (ø)
ruby-backend 82.70% <81.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get some unit tests for all this new functionality? :-)

@jmthomas jmthomas self-requested a review February 17, 2025 05:35
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was branched off #1901. That's ok I guess but I commented on some of that in this PR. Also we need some unit tests.

@ryanmelt
Copy link
Member Author

Would love someone to add a unit test for ThreadManager ;)

@jmthomas jmthomas self-requested a review February 19, 2025 03:45
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with unit tests!

@ryanmelt ryanmelt merged commit 482621e into main Feb 20, 2025
30 checks passed
@ryanmelt ryanmelt deleted the kill_on_thread_crash branch February 20, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi microservice doesn't die if an embedded microservice dies Thread.abort_on_exception not working fully
2 participants