Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors] Remove non-existing arguments for generate_id #2914

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[Connectors] Remove non-existing arguments for generate_id #2914

merged 1 commit into from
Nov 5, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Nov 5, 2024 •
edited
Loading

Proposed changes

  • Remove non-existing arguments for generate_id for following connectors
    • crits
    • group ib
    • ransomware live
    • recorded future
    • greynoise
    • hybrid analysis sandbox
    • orion malware
    • recorded future enrichment

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Nov 5, 2024
@helene-nguyen helene-nguyen self-assigned this Nov 5, 2024
@helene-nguyen helene-nguyen changed the title [Connectos] Remove non-existing arguments for generate_id [Connectors] Remove non-existing arguments for generate_id Nov 5, 2024
@helene-nguyen helene-nguyen merged commit 1b30350 into master Nov 5, 2024
3 checks passed
@helene-nguyen helene-nguyen deleted the issue/2908-generate-id branch November 5, 2024 10:58
@helene-nguyen helene-nguyen linked an issue Nov 5, 2024 that may be closed by this pull request
[group-ib] collection apt/threat error #2908
Closed
This was referenced Nov 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-julien richard-julien richard-julien approved these changes

@romain-filigran romain-filigran Awaiting requested review from romain-filigran

Assignees

@helene-nguyen helene-nguyen

Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[group-ib] collection apt/threat error
2 participants
@helene-nguyen @richard-julien