Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors] Re add missing generate_id arguments #2920

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[Connectors] Re add missing generate_id arguments #2920

merged 1 commit into from
Nov 20, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Nov 6, 2024 •
edited
Loading

Proposed changes

  • Re add missing generate_id arguments

Rollback of this PR: #2914, wait for OpenCTI-Platform/client-python#748 to be merged ⚠️

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added filigran team use to identify PR from the Filigran team do not merge Do not merge this PR until this tag will be removed multi-repository When a PR requires several repository changes labels Nov 6, 2024
@helene-nguyen helene-nguyen self-assigned this Nov 6, 2024
@helene-nguyen helene-nguyen linked an issue Nov 6, 2024 that may be closed by this pull request
[Connectors] Threat Actor entity type to define for some connectors and missing arguments for Malware Analysis when generate IDs #2916
Closed
@helene-nguyen
Copy link
Member Author

@richard-julien PR opened but need to wait for OpenCTI-Platform/client-python#748 to be merged
ThreatActor Group or Individual is added following our discussion

@helene-nguyen helene-nguyen removed the do not merge Do not merge this PR until this tag will be removed label Nov 20, 2024
Megafredo
Megafredo approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Megafredo Megafredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your update on the missing arguments seems right to me. Good Job ;)

@helene-nguyen helene-nguyen merged commit aa32b74 into master Nov 20, 2024
3 checks passed
@helene-nguyen helene-nguyen deleted the issue/2916-generate-id branch November 20, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

@richard-julien richard-julien Awaiting requested review from richard-julien

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team multi-repository When a PR requires several repository changes
Projects
None yet
Milestone
No milestone
2 participants
@helene-nguyen @Megafredo