keyboard-service: fix syntax error in task macro#640
Merged
williampMSFT merged 1 commit intoOpenDevicePartnership:mainfrom Dec 16, 2025
Merged
Conversation
williampMSFT
requested review from
gjpmsft,
jerrysxie,
kurtjd and
madeleyneVaca
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a syntax error in the keyboard-service task macro where the macro parameter name didn't match its usage within the macro body. The issue would have caused compilation failures when users attempted to invoke the impl_host_request_task! macro.
Key Changes:
- Renamed the macro parameter from
$kb_int_ty:tyto$i2c_slave_ty:tyto match its actual usage in the macro body
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
felipebalbi
approved these changes
Dec 16, 2025
kurtjd
approved these changes
Dec 16, 2025
jerrysxie
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#594 moved the responsibility for declaring async tasks from embedded-services to the application layer. To support this, some tasks that needed to be generic over a type (which is not directly supported by embassy) made into macros that emit a function that uses a concrete type. The application layer is required to call that macro and then implement a task that invokes the generated function.
However, in the case of the keyboard service, there appears to be a typo causing the name of the type identifier being passed into the macro to not match the name of the type identifier that is actually used in the macro, resulting in a compilation error whenever a user tries to actually invoke the macro. This change fixes the typo.