Skip to content

[Bug]: Replace debug_assert() in core_load_pe_image() with return value #1108

@makubacki

Description

@makubacki

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

The debug_assert!():

debug_assert!(false);

Creates unnecessarily complex testing and inconsistent expectations for handling. The debug_assert!() can stay if desired but an error code should be returned as well.

Expected Behavior

Errors are returned from the function when an error occurs.

Steps To Reproduce

Review the code in core_load_pe_image() in patina/patina_dxe_core/src
/image.rs.

Build Environment

N/A

Version Information

Tag: v16.0.0

Urgency

Low

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

Metadata

Metadata

Assignees

Labels

type:bugSomething isn't workingurgency:lowLittle to no impact

Type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions