Remove debug asserts in tests [Rebase & FF[ #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
joschock
approved these changes
Nov 26, 2025
Javagedes
reviewed
Nov 26, 2025
Javagedes
reviewed
Nov 26, 2025
Javagedes
reviewed
Nov 26, 2025
Javagedes
approved these changes
Nov 26, 2025
vineelko
approved these changes
Nov 26, 2025
- Return `EfiError::LoadError` for an invalid HII resource section. - Remove complex logic in some unit tests for testing different conditions with debug asserts enabled or disabled. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
remove_debug_asserts_in_tests
branch
from
6beb605 to
3032587
Compare
makubacki
force-pushed
the
remove_debug_asserts_in_tests
branch
from
3032587 to
4c73df3
Compare
Debug assertions will no longer be enabled when running unit tests. While the assertions can still be used in the code, they are removed from unit test expectations. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
To have unit tests stay focused on production expectations and reduce complexity in tests for managing debug assertions, debug assertions are disabled in the `test` profile. - Debug asserts may still be used but we're avoiding writing tests around them - Non-debug asserts may be used and tested in unit tests Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
remove_debug_asserts_in_tests
branch
from
4c73df3 to
2f00bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: The debug asserts in the component parameter validation code in the first phase of enforcing strong parameter validation as described in #1122.
patina_dxe_core/image: Remove debug asserts from unit tests
Closes #1108
EfiError::LoadErrorfor an invalid HII resource section.conditions with debug asserts enabled or disabled.
Remove debug_assert!() expectations in unit tests
Debug assertions will no longer be enabled when running unit tests.
While the assertions can still be used in the code, they are removed
from unit test expectations.
Disable debug assertions in the test profile
Closes #1054
To have unit tests stay focused on production expectations and
reduce complexity in tests for managing debug assertions, debug
assertions are disabled in the
testprofile.around them
How This Was Tested
cargo make allIntegration Instructions