patina_dxe_core: move image.rs to pi_dispatcher
#1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Javagedes
force-pushed
the
personal/joeyvagedes/image-to-pi-dispatcher-again
branch
from
6bfbfa2 to
8b0238a
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Javagedes
force-pushed
the
personal/joeyvagedes/image-to-pi-dispatcher-again
branch
from
8b0238a to
4fa1e67
Compare
Javagedes
force-pushed
the
personal/joeyvagedes/image-to-pi-dispatcher-again
branch
from
4fa1e67 to
ee3c159
Compare
os-d
approved these changes
Jan 5, 2026
joschock
approved these changes
Jan 5, 2026
Javagedes
force-pushed
the
personal/joeyvagedes/image-to-pi-dispatcher-again
branch
from
ee3c159 to
4b0e86f
Compare
Javagedes
force-pushed
the
personal/joeyvagedes/image-to-pi-dispatcher-again
branch
from
4b0e86f to
b565423
Compare
makubacki
approved these changes
Jan 5, 2026
This commit removes the global static variable for image metadata and instead makes it a member of the PiDispatcher struct.
Javagedes
force-pushed
the
personal/joeyvagedes/image-to-pi-dispatcher-again
branch
from
b565423 to
02cf4dd
Compare
Javagedes
deleted the
personal/joeyvagedes/image-to-pi-dispatcher-again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit moves
image.rsas a sub-module underneathpi_dispatcherand removes the global static variable in favor of a field of thePiDispatcherstruct of the core.This commit also updates all tests to not rely on the global static, and instead a non-global static core.
NOTE: This PR changes no logic. All logical changes were handled in #1192. This PR only moves the code and replaces
STATICusage withselfusage.How This Was Tested
CI, continues to boot to shell.
Integration Instructions
N/A