Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifically dependent continunants without bearer #1305

Closed
5 tasks
l-emele opened this issue Sep 20, 2022 · 18 comments · Fixed by #1485
Closed
5 tasks

Specifically dependent continunants without bearer #1305

l-emele opened this issue Sep 20, 2022 · 18 comments · Fixed by #1485
Assignees
Labels
[B] restructure Restructuring existing parts of the ontology OEKG important for knowledge graph generation

Comments

@l-emele
Copy link
Contributor

l-emele commented Sep 20, 2022

Description of the issue

As a specifically dependent continuant (SDC) depends on an independent continuant, every SDC should have an has bearer axiom. But currently a lot of them do not have.

Ideas of solution

  • For imported classes check whether axioms were accidentally not imported:
class bearer
specifically dependent continuant independent continuant?
quality independent continunant?
relational quality independent continunant?
realizable entity independent continunant?
disposition independent continunant?
function independent continunant?
role independent continunant?
  • Add has bearer axioms to OEO defined SDC classes:
class bearer
policy instrument government (not yet defined). Alternatively: organisation?
rotor diameter wind energy converting unit or wind rotor
hub height wind energy converting unit
planned availability power plant
unplanned availability power plant
resolution data set
spatial resolution georeferenced data set (not yet defined)
temporal resolution time series
state of matter portion of matter
demand person or organisation or object
energy storage artifical object
greenhouse effect dispostion 'portion of matter' 'has state of matter' value gaseous
volatility portion of matter
agent person or organisation
good role continuant
market exchange role organisation?
organisation role aggreate of people (not yet defined1)
waste role object aggregate

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words

Footnotes

  1. Maybe an intermediate class in between object aggregate and population.

@l-emele l-emele added [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Sep 20, 2022
@l-emele l-emele added this to the oeo-release-1.13.0 milestone Sep 20, 2022
@l-emele l-emele self-assigned this Sep 20, 2022
@l-emele l-emele added the OEKG important for knowledge graph generation label Sep 21, 2022
@l-emele
Copy link
Contributor Author

l-emele commented Sep 22, 2022

OEO Dev meeting 44:

@fabianneuhaus validates the BFO classes, with Martins help
@l-emele implements the one that are obvious. There unclear ones will be discussed later.

l-emele added a commit that referenced this issue Sep 22, 2022
l-emele added a commit that referenced this issue Sep 28, 2022
…-bearer

Add `has bearer` axioms to subclasses of `realizable entity` #1305
@stap-m
Copy link
Contributor

stap-m commented Oct 4, 2022

We have at least two BFO classes, that we modified for the energy usecase, which are quality and role.
For both, we should add 'has bearer' some (energy or 'portion of matter'), I guess.
And therefore, this axiom should also be added to the parent classes realizable entity and specifically dependent continuant.
And the same axiom should be added to demand and energy demand (direct subclasses of realizable entity).

@l-emele @fabianneuhaus @MGlauer do you agree?

@stap-m stap-m self-assigned this Oct 4, 2022
@l-emele
Copy link
Contributor Author

l-emele commented Oct 24, 2022

I agree.

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Oct 24, 2022
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Nov 9, 2022
@fabianneuhaus
Copy link
Contributor

fabianneuhaus commented Nov 15, 2022

I suggest:
'Specifically Dependent Continuant' SubClassOf: has_bearer some 'Independent Continuant'

That's obviously true and -- if we need a source -- it is also documented in the "Building Ontologies with BFO" book (page 96):
"A specifically dependent continuant is a dependent continuant that depends on some specific independent continuant that is its bearer. "

That will be inherited by qualities etc., so we need no additional axioms.

The suggested axiom:
Quality has_bearer some (energy or 'portion of matter')
seems to be too narrow to me. E.g., consider the reservoir of a pumped-storage hydroelectricity installation. That reservoir (it could be a lake or a large cave) is an immaterial entity, more specifically a site. Nevertheless it has qualities, e.g., a volume -- which contradicts the proposed axiom.
(Note that sites usually depend on some material entities, e.g., rocks that form a cave. Nevertheless, they are not material entities. This is the case even if they are filled with portion of matter like air or water.)

@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Nov 15, 2022
@stap-m
Copy link
Contributor

stap-m commented Nov 23, 2022

'Specifically Dependent Continuant' SubClassOf: has_bearer some 'Independent Continuant'>

'Specifically Dependent Continuant' SubClassOf: has_bearer some ('Independent Continuant'> or energy).

Or to be more explicit:

class bearer
specifically dependent continuant 'independent continuant' or energy
quality 'independent continunant' or energy
relational quality 'independent continunant'
realizable entity 'independent continunant' or energy
disposition 'independent continunant'
function 'independent continunant'
role 'independent continunant' or energy

@stap-m
Copy link
Contributor

stap-m commented Nov 23, 2022

Quality has_bearer some (energy or 'portion of matter') seems to be too narrow to me. E.g., consider the reservoir of a pumped-storage hydroelectricity installation. That reservoir (it could be a lake or a large cave) is an immaterial entity, more specifically a site. Nevertheless it has qualities, e.g., a volume -- which contradicts the proposed axiom.

True. I think, we wanted to narrow the axiom for energy only: energy subClassOf 'has bearer' some 'material entity'.1 (I mixed up material entity and portion of matter in my comment, sorry). Hence, a site cannot not be bear of an energy in that case. Only the portion of rock that forms the site, to stay with the example.
reservoir is actually classified as artificial object in OEO. Do we have to reconsider that classification?

Footnotes

  1. Energy is a quality of material entities which manifests as a capacity to perform work (such as causing motion or the interaction of molecules)

@stap-m
Copy link
Contributor

stap-m commented Dec 1, 2022

demand | person or organisation or object

This comes from the def of demand obviously. person is subclass of object, i.e. demand SubClassOF 'has bearer' some object or organisation?

@stap-m
Copy link
Contributor

stap-m commented Dec 1, 2022

good role | continuant

We cannot extend the bearer of the subclass compared to the parent class. Instead 'independent continunant' or energy, like its parent property role, I'd suggest.

@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Dec 20, 2022
@l-emele l-emele removed this from the oeo-release-1.13.0 milestone Jan 24, 2023
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Jan 30, 2023
@l-emele
Copy link
Contributor Author

l-emele commented Jan 30, 2023

Quality has_bearer some (energy or 'portion of matter') seems to be too narrow to me. E.g., consider the reservoir of a pumped-storage hydroelectricity installation. That reservoir (it could be a lake or a large cave) is an immaterial entity, more specifically a site. Nevertheless it has qualities, e.g., a volume -- which contradicts the proposed axiom.

True. I think, we wanted to narrow the axiom for energy only: energy subClassOf 'has bearer' some 'material entity'.1 (I mixed up material entity and portion of matter in my comment, sorry). Hence, a site cannot not be bear of an energy in that case. Only the portion of rock that forms the site, to stay with the example. reservoir is actually classified as artificial object in OEO. Do we have to reconsider that classification?

I'll open a separate issue for that.

@l-emele
Copy link
Contributor Author

l-emele commented Jan 30, 2023

Any feedback to my latest suggestions? It would be great to solve this.

I agree to your suggestions.

@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Feb 19, 2023
@stap-m
Copy link
Contributor

stap-m commented Feb 21, 2023

If there are no objections, I'll implement.

@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Feb 21, 2023
@l-emele
Copy link
Contributor Author

l-emele commented Feb 21, 2023

Go for it! 🚀

@stap-m
Copy link
Contributor

stap-m commented Feb 21, 2023

My attempt is to put the axioms into oeo-import-edits.owl, yet an answer to #1484 is needed first.

stap-m added a commit that referenced this issue Feb 22, 2023
stap-m added a commit that referenced this issue Feb 22, 2023
stap-m added a commit that referenced this issue Feb 22, 2023
@stap-m
Copy link
Contributor

stap-m commented Feb 23, 2023

from oeo-dev-54:
since 'has bearer' is inherited by its parent, we'll try sdc <= ((has_bearer some ic) OR ((has_bearer some energy) AND (role OR ...))

@stap-m stap-m mentioned this issue Mar 3, 2023
5 tasks
@stap-m
Copy link
Contributor

stap-m commented Mar 3, 2023

EDIT: sorry, my comment on the inheritance was wrong, it is not a problem here.

@stale stale bot added stale already discussed issues that haven't got worked on for a while and removed stale already discussed issues that haven't got worked on for a while labels Mar 18, 2023
@stap-m
Copy link
Contributor

stap-m commented Mar 24, 2023

The bearer of policy instrument needs a discussion, see #1507

@stap-m
Copy link
Contributor

stap-m commented Mar 24, 2023

The good role is currently defined as role of a continuant, which is obviously an artifact and exceeds the 'energy or independent continuant' restriction. I'll fix that, too.

stap-m added a commit that referenced this issue Mar 24, 2023
stap-m added a commit that referenced this issue Mar 24, 2023
stap-m added a commit that referenced this issue Mar 24, 2023
stap-m added a commit that referenced this issue Mar 24, 2023
stap-m added a commit that referenced this issue Mar 24, 2023
stap-m added a commit that referenced this issue Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology OEKG important for knowledge graph generation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants