Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has bearer axioms to subclasses of realizable entity #1305 #1310

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

l-emele
Copy link
Contributor

@l-emele l-emele commented Sep 22, 2022

Summary of the discussion

Implement the axioms that are already solved in the table of issue #1305.

Type of change (CHANGELOG.md)

Added axioms

  • 'hub height' 'has bearer' some 'wind energy converting unit'
  • 'rotor diameter' 'has bearer' some ('wind energy converting unit' or 'wind rotor')
  • 'planned availability' 'has bearer' some 'power plant'
  • 'unplanned availability' 'has bearer' some 'power plant'
  • resolution 'has bearer some 'data set'
  • 'temporal resolution' 'has bearer' some 'time series'
  • demand 'has bearer' some (person or organisation or object)
  • 'state of matter' 'has bearer' some 'portion of matter'
  • 'greenhouse effect disposition' 'has bearer' some ('portion of matter' and ('has state of matter' value gaseous))
  • volatility 'has bearer' some 'portion of matter'
  • agent 'has bearer' some 'person or organisation'
  • 'good role' 'has bearer' some continuant'
  • 'waste role' 'has bearer' some 'object aggregate'

Workflow checklist

Automation

No automation, as issue #1305 is only partly solved by this PR.

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module labels Sep 22, 2022
@l-emele l-emele self-assigned this Sep 22, 2022
@l-emele l-emele marked this pull request as ready for review September 22, 2022 10:15
@l-emele l-emele requested a review from lumi321 September 28, 2022 08:42
@l-emele
Copy link
Contributor Author

l-emele commented Sep 28, 2022

This PR is now open for almost a week without review. So I added @lumi321 as additional reviewer.

Copy link
Contributor

@lumi321 lumi321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@l-emele
Copy link
Contributor Author

l-emele commented Sep 28, 2022

Thanks for the quick review!

@l-emele l-emele merged commit 40abe1c into dev Sep 28, 2022
@l-emele l-emele deleted the feature-1305-sdc-has-bearer branch September 28, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants