Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for 3.2.0 release (jjonkman review) #1178

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

andrew-platt
Copy link
Collaborator

This is ready to merge.

This PR contains a few requested corrections for the 3.2.0 release in review #1175 (review)

Corrections include

  • Correction to angle perturbation for TStC and SStC to use small angle (this now matches the implementation plan for linearization)
  • Correction to angle perturbation for tower in AD15 to use small angle (this now matches the implementation plan for linearization)
  • Typo in api_change.rst
  • relocate TurbSim entry in api_change.rst
  • removal of incorrect line of text in FAST.Farm documentation in fast.farm/index.rst

Tests
I don't believe any regression test results will be affected.

The change in the angular perturbations to use small angle assumptions instead of large angles has a very small effect in the resulting DCM (small angle method is slightly more accurate near 0, so we use it when we know angles remain small). So the DCM produced using the small angle method will be very slightly different than the large angle forumaltion, but the difference is very small. The effect of this on the linearization of the AD15 tower becomes negligible since the angular perturbation of tower nodes in AD15 has little effect in the aero loads. Similarly the structural controls (StCs) are not very sensitive to small angular changes, so the minor difference in the DCM will have no impact on the linearization results.

…cture (SStc)

This now aligns with the 3D rotation implementation plan (in docs/OtherSupporting).
@andrew-platt andrew-platt added this to the v3.2.0 milestone Jul 13, 2022
@andrew-platt andrew-platt requested a review from jjonkman July 13, 2022 00:35
@andrew-platt andrew-platt self-assigned this Jul 13, 2022
@andrew-platt andrew-platt changed the title B/lin doc corrections 3.2.0 Corrections for 3.2.0 release (jjonkman review) Jul 13, 2022
@andrew-platt andrew-platt mentioned this pull request Jul 13, 2022
10 tasks
@rafmudaf rafmudaf merged commit 0c2a541 into OpenFAST:dev Jul 13, 2022
@jjonkman
Copy link
Collaborator

jjonkman commented Jul 13, 2022

I agree that the effect will be small. I just want to be consistent in how the meshes that get mapped together treat 3D orientations in the linearization. Thanks for addressing my comments.

@andrew-platt andrew-platt deleted the b/LinDocCorrections_3.2.0 branch July 15, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants