Updates to openfast_io to match current dev branch API #2361
+6,173
−10,545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankchetan
changed the title
|
I haven't checked through the code, but just noticed there is a new input in the AeroDyn input file that wasn't included in any of the regression tests yet (adding that line to all AD input files in PR #1295).
|
Hatch, Cmake and GitHub actions
bjonkman
reviewed
Aug 26, 2024
| if self.fst_vt['AeroDyn15']['UAMod'] == 2: | ||
| raise Exception('OLAF is called with unsteady airfoil aerodynamics, but OLAF currently only supports UAMod == 1') #TODO: need to check if this holds true now | ||
| if self.fst_vt['AeroDyn15']['UA_Mod'] == 2: | ||
| raise Exception('OLAF is called with unsteady airfoil aerodynamics, but OLAF currently only supports UA_Mod == 1') #TODO: need to check if this holds true now |
There was a problem hiding this comment.
I haven't read much of this code, but I don't understand this comment. The UnsteadyAero module doesn't allow UA_Mod to be 1, including when it is called from OLAF.
There was a problem hiding this comment.
Thank for catching that! I think I missed that with new AD15 API updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is NOT ready to merge until TODOs below are cleared.
Feature or improvement description
Updates to the
openfast_iolibrary to match the currentdevbranch API. Once merged, will provide OpenFAST users with an up-to-date library that they can import to read/write OpenFAST files. This follows thefst_vtnested dictionary structure developed underWEISand heavily borrows code from there.This library is currently limited to
OpenFASTand does not work withFAST.Farmor any of the module drivers.Related PRs: #2333, #2188
Related issue, if one exists
#2233, #2261, #1851
Impacted areas of the software
openfast_io
Additional supporting information
Test results, if applicable
pytestadded to span most OpenFAST input files (drivers not included). Based on @andrew-platt comments in #2233, need to introduce automated testing.TODO:
openfast_iosince most NREL tools likeWEISandWISDEMprefer it.PoetryfileWe will continue usingPoetryold APIwarning thrown by AD15APIs to upgrade before merge: