Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD: Remove the misleading CBMod input #2401

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

luwang00
Copy link
Contributor

@luwang00 luwang00 commented Aug 30, 2024

Feature or improvement description
This pull request slightly modifies the SubDyn input file by removing the CBMod T/F switch. This input can be misleading because irrespective of CBMod, SubDyn always transforms the equations of motion to be in terms of Guyan and Craig-Bampton modes. Setting CBMod to false simply lets SubDyn retain all Craig-Bampton modes.

To better reflect how SubDyn actually functions, the CBMod switch is removed. Instead, if Nmodes>=0, SubDyn will function as if CBMod is true in previous versions. Alternatively, setting Nmodes<0 will let SubDyn retain all Craig-Bampton modes, recovering the same behavior with CBMod set to false in previous versions.

The user documentation for SubDyn is updated to reflect the removal of CBMod from the primary input file. The removal of GuyanLoadCorrection from the input file is also briefly explained (see PR #2203).

Impacted areas of the software
SubDyn, Docs

Test results, if applicable
There is no change to existing test results. All r-test SubDyn input files are updated by removing CBMod.

@andrew-platt
Copy link
Collaborator

Are there documentation changes required, or is the documentation for this part missing?

@luwang00
Copy link
Contributor Author

luwang00 commented Sep 3, 2024

@andrew-platt I have not updated the documentation for SubDyn yet. We also need to address the removal of GuyanLoadCorrection in the input file. I can quickly address these two changes and add to this PR. (SD theory manual also needs to be updated, but that will have to wait I think.)

@luwang00
Copy link
Contributor Author

luwang00 commented Sep 4, 2024

Hi @andrew-platt, I updated the SD user manual regarding the removal of the two inputs GuyanLoadCorrection and CBMod.

@andrew-platt andrew-platt merged commit 8a90413 into OpenFAST:dev Sep 4, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants