Correct frequency error in AeroDyn driver prescribed motions #2370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged (pending r-test results).
There was an error in the AeroDyn driver script that reads inputs from the driver input file. When prescribing sinusoidal motions, the frequency was multiplied by 2pi in two different places, resulting in inaccurate frequencies being used. The repeated multiplication occurred in the setSimpleMotion subroutine, which was only called for a combined cases analysis or when BasicHAWTFormat was True.
For a surge amplitude of 2 m and period of 6 s, an 18 s simulation gave the following, with 2pi/6 (~1) cycles per second (~18 cycles total):
With the bug fix included here, an 18 s simulation gave the following (1/6 cycles per second, total of 3 cycles):