Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct frequency error in AeroDyn driver prescribed motions #2370

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

hkross
Copy link
Contributor

@hkross hkross commented Aug 13, 2024

This pull request is ready to be merged (pending r-test results).

There was an error in the AeroDyn driver script that reads inputs from the driver input file. When prescribing sinusoidal motions, the frequency was multiplied by 2pi in two different places, resulting in inaccurate frequencies being used. The repeated multiplication occurred in the setSimpleMotion subroutine, which was only called for a combined cases analysis or when BasicHAWTFormat was True.

For a surge amplitude of 2 m and period of 6 s, an 18 s simulation gave the following, with 2pi/6 (~1) cycles per second (~18 cycles total):

Screenshot 2024-08-13 at 1 06 27 PM

With the bug fix included here, an 18 s simulation gave the following (1/6 cycles per second, total of 3 cycles):

Screenshot 2024-08-13 at 1 03 48 PM

Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@andrew-platt
Copy link
Collaborator

The ad_BAR_CombinedCases was using a platform surge motion with the incorrect input frequency, so the results from that case changed. I'll get an update in and push a commit.

@hkross
Copy link
Contributor Author

hkross commented Aug 13, 2024

The ad_BAR_CombinedCases was using a platform surge motion with the incorrect input frequency, so the results from that case changed. I'll get an update in and push a commit.

There are a couple others that also used a prescribed motion but passed, and I'm trying to figure out why.

@andrew-platt andrew-platt merged commit bdc513c into OpenFAST:dev Aug 14, 2024
63 checks passed
@hkross hkross deleted the bug/AD_Driver_Motion branch August 19, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants