Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Map++ C API #2394

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Fixes to Map++ C API #2394

merged 5 commits into from
Aug 28, 2024

Conversation

sanguinariojoe
Copy link

Feature or improvement description

I am making a more consistent C API:

  • Not exposing the internal data structures to the final user
  • Importing the required headers on mapapi.h
  • Enclosing the mapapi.h content on a extern C (for C++ only)

Related issue, if one exists
None

Impacted areas of the software
Map++

Additional supporting information
Not much else to add

Test results, if applicable

  • Update the documentation version in docs/conf.py
  • Update the versions in docs/source/user/api_change.rst
  • Verify readthedocs builds correctly
  • Create a tag in OpenFAST
  • Create a merge commit in r-test and add a corresponding tag
  • Compile executables for Windows builds
    • FAST_SFunc.mexw64
    • OpenFAST-Simulink_x64.dll
    • openfast_x64.exe
    • DISCON.dll

@deslaughter deslaughter self-requested a review August 28, 2024 15:39
@deslaughter deslaughter self-assigned this Aug 28, 2024
@deslaughter deslaughter added this to the v4.0.0 milestone Aug 28, 2024
@deslaughter deslaughter merged commit 29b60df into OpenFAST:dev Aug 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants