MAP: change strncpy to use macro MAP_STRNCPY #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how macro MAP_STRCPY works, MAP_STRNCPY points to either strncpy or strncpy_s depending on compiler used
|
@sanguinariojoe, we think this may be a solution that is more consistent with the existing code. |
deslaughter
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge.
Feature or improvement description
Some compilers do not support the
strncpy_sroutine. Replacing this call with a call to a macro who's definition is based on which compiler is in use. This new macroMAP_STRNCPYis based on theMAP_STRCPYmacro and points to eitherstrncpyorstrncpy_s.Related issue, if one exists
Supersedes PR #2417
Original issue mentioned in comment here: 93e2d27#r14664285 from PR #2394
Impacted areas of the software
MAP module compilation only
Additional supporting information
Evidently incompatibilities between MSVC and gcc were run into before. I suspect this is why @mmasciol added the macro definitions for
MAP_STRCPYduring initial MAP development in ~2011.Test results, if applicable
No tests exist for this, so nothing changes.