-
Notifications
You must be signed in to change notification settings - Fork 509
MoorDyn-SeaState Coupling #2705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrew-platt
merged 24 commits into
OpenFAST:dev-cbind
from
RyanDavies19:MD_SS_coupling
Apr 28, 2025
Merged
MoorDyn-SeaState Coupling #2705
andrew-platt
merged 24 commits into
OpenFAST:dev-cbind
from
RyanDavies19:MD_SS_coupling
Apr 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng FF from unnecessary deallocation call (already was deallocated)
7405abd to
1437ea6
Compare
rafmudaf
approved these changes
Apr 2, 2025
7 tasks
Contributor
Author
|
Change to draft until currents are added |
aed5147 to
39994b1
Compare
Contributor
Author
|
Ready to merge. Updated regression tests PR will be made to r-test, updated docs PR will be made to MD-C. Wave spreading will come in a later PR. |
deslaughter
reviewed
Apr 25, 2025
6b0b804 to
b7d6599
Compare
…x for zero length rods, seg fault fix for current profile bigger than 100.
9e67acb to
cda308f
Compare
This was referenced Jun 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This is the beginning of coupling MoorDyn to SeaState. So far it only supports waves, no currents. MoorDyn now has three options for water kinematics:
Options 1 and 2 are specified in the
WaterKin.datfile that MoorDyn currently requires for water kinematics (there are modifications for specifying the current grid if using option 2. They follow the same approach as defining the Z grid point data for waves). The input variablesWaveKinModandCurrentModtrigger which method is used; they must be equal or one must be zero. Option 3 is triggered by the keywordSeaState(case insensitive) in theWaterKinflag in the main MoorDyn input file.This is currently only set up to support waves, currents are on the todo list.Much of the approach follows how the SeaState
WaveFieldpointer is passed into Hydrodyn. The MoorDyn driver calls SeaState Init and then passes MoorDyn the pointer. Otherwise,FAST_subsandFAST_Farm_subswill pass it in. In the case of FAST Farm, option 3 (the full SeaState coupling) is not allowed because there is not a farm level SeaState instance. Instead (if using option 2),FAST_Farm_subswill pass MoorDyn theWaveFieldpointer from the first SeaState instance, because it contains the same seed information as all the other instances. This will change in future development once the farm level SeaState is implemented.Impacted areas of the software
MoorDyn
OpenFAST
FAST.Farm
C-Bindings
Test results, if applicable
Tested for no seg faults when running the three SeaState - MoorDyn coupling options in OpenFAST and FF.
Tested for numerical accuracy by matching frequency of input waves with MD outputs, and matching current speeds w/ MD output current speeds.
TODO before release to main OpenFAST dev branch
These will be addressed in future PR's to the dev-cbind branch
Add wave directional spreading into MoorDyn for WaterKin = 2 (SeaState inputs to the MoorDyn grid)