VS build: fix MD, add SeaStateS_c_binding and update GH deploy action
#2866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved: - NTWC_C_Binding.f90 out of library (for better project split out) - *_C_Binding.f90 to bottom since this is the top level for the DLL build
The random number code (RANLUX.f90 and NWTC_RandomNumber.f90) are not included in the NWTC library module. So for clarity in the project breakdown, I'm splitting them out. RanLux was separated out in some of the projects, but ended up with VTK grouped with it.
andrew-platt
added
System: Visual Studio
System: GH actions
Collaborator
Author
|
Workflow Edit: this one failed for reasons I do not understand. Filed bug report with GH here: actions/runner-images#12412 |
andrew-platt
force-pushed
the
b/VSbuild_cbinding
branch
3 times, most recently
from
231cd62 to
adf1b6b
Compare
andrew-platt
force-pushed
the
b/VSbuild_cbinding
branch
from
adf1b6b to
2627718
Compare
Collaborator
Author
|
Rerunning the |
andrew-platt
changed the title
SeaStateS_c_binding and update GH deploy action
deslaughter
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge.
Feature or improvement description
The Visual Studio projects for MoorDyn were never updated to include the coupling with SeaState. This PR adds the necessary SeaState files to the MD projects, adds a VS project for
SeaState_C_Binding.dll, and includes some rearrangement of the file grouping in the HD Visual Studio projects. Also adds the building of the SeaState c-bindings DLL to GitHubdeployaction.Related issue, if one exists
Linking of SeaState into MoorDyn: #2705
Impacted areas of the software
Visual Studio projects, and GitHub action to build the executables.
Additional supporting information
The Visual Studio projects have been reworked in tight-coupling (for v5.0).
Test results, if applicable
No test results change