Simplify GitHub Action for regression tests (backport from dev-tc)#2825
Simplify GitHub Action for regression tests (backport from dev-tc)#2825andrew-platt merged 2 commits intoOpenFAST:rc-4.0.5from
Conversation
|
With 4 threads on OpenMP, the Not sure if it just ran on different hardware or if something else changed (memory layout for example). |
| needs: build-openfast-release | ||
| rtest-OF-offshore: | ||
| runs-on: ubuntu-24.04 | ||
| needs: build-all-release |
There was a problem hiding this comment.
| needs: build-all-release | |
| needs: build-all-release | |
| OMP_NUM_THREADS: 2 |
Setting to 2 threads here to match old method. Might get the 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth to match the baseline (we don't have any artifacts from this case passing on main or .log files in the repo to check against).
|
Regarding the |
d4c2fcb to
e4935e7
Compare
|
There is something in the baseline for Other than the issue with the Simulink test, which is caused by Matlab's mpm servers and beyond our control, the PR is ready to be merged. |
This PR is ready to be merged.
Feature or improvement description
This PR introduces a slightly more streamlined process for the regression tests run in Github Actions. It reduces the amount of caching used in the build process by compiling most of the executables in one step and then using them to run the tests so only one workspace is cached. The same regression tests are still being run, but some have been grouped into new jobs.
This change also separates out the Matlab Simulink build and test which is currently failing due to an outage in Matlab's servers. That issue is being tracked at matlab-actions/setup-matlab#146.
Impacted areas of the software
automated-dev-tests.ymlAdditional supporting information
This PR also revealed an issue with the
5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowthregression test which has to be run withOMP_NUM_THREADSnot specified to match the test baseline. This will be corrected in the future by settingOMP_NUM_THREADS=1and regenerating the baseline.Test results, if applicable
No tests were changed and the Simulink test cases will start working once the Matlab outage is resolved.