Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test and OpenFAST updates #41

Closed
wants to merge 463 commits into from
Closed

Regression test and OpenFAST updates #41

wants to merge 463 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2017

Regression Test

  • New failure criteria
if channelRange < 1 {
	norm = InfinityNorm
} else {
	norm = InfinityNorm / channelRange
}
  • Optional error plotting and results summary provided with matplotlib generated files embedded into html
  • Improved results output when running the regression test manually
  • Improved control when running the regression test manually - single case execution, generate plots without running the case (great for debugging)
  • Added abstraction and improved the API's to the custom python infrastructure

OpenFAST

  • Export unpacked binary output file
  • Git commit is embedded in the binary when built with CMake; VS integration is on the way
    -- Including the git info in the module specific outputs is more involved since each module handles its own I/O and the I/O code is tucked into larger subroutines - saving for future work
  • Fix BeamDyn, BeamDyn driver, and OrcaFlex driver precision-type bugs
  • Replace unicode with ascii characters in output
  • Additional meta data is printed in the OpenFAST log:
**************************************************************************************************
 OpenFAST

 Copyright (C) 2017 National Renewable Energy Laboratory

 This program comes with ABSOLUTELY NO WARRANTY. See the "license.txt" file distributed with this
 software for details.
 **************************************************************************************************

 OpenFAST v8.17.01c-dev-dc586c7*
 Compile Info:
  - Architecture: 64 bit
  - Precision: double
 Execution Info:
  - Date: 08/28/2017
  - Time: 19:55:51-0600

 OpenFAST input file heading:
     FAST Certification Test #06: AOC 15/50 with many DOFs with gen start, loss of grid, and
     tip-brake shutdown. Many parameters are pure fiction.

 Running ElastoDyn.
 Running AeroDyn14.
 Running InflowWind.
 Running ServoDyn.
  Timestep: 0 of 35 seconds.

TO DO BEFORE MERGE

  • Verify on peregrine & windows
  • Update r-test baseline solutions for all machine/compiler combinations
  • Include OpenFAST 0.1.0 - OpenFAST 1.0.0 comparison

bjonkman and others added 30 commits May 9, 2017 23:36
- reorganized more of the code (including renamed variables) for readability.
- changed the BeamDyn coordinate system (X aligned with blade) to use the IEC coordinate system (Z aligned with blade). 
- fixed weird physics in the BeamDyn driver's BD_InputSolve routine (spinning blades didn't actually spin). THIS WILL CHANGE RESULTS FROM THE BEAMDYN STANDALONE DRIVER CODE.
- BD driver has the ability to add point loads at arbitrary locations (though that is not documented here)
…appropriate one based on machine type and compiler
…ss a ctest warning when it doesnt find config file
this can now be put in the SetParameters routine
…nsistent and to build debug/release win32/x64. Also created additional solutions for both which include the registry as a project.
Updated AFI to version v1.01.01a
Added version number to UnsteadyAero: v1.01.00a
All three modules have a version date of 10-May-2017
Adjusted all UnsteadyAero.f90 eqn #s to match document, "The Unsteady Aerodynamics Module for FAST 8" by Rick Damiani and Greg Hayman, 28-Feb-2017
Fixed bug with eqn 1.39 in UnsteadyAero (UAMod=2)
Fixed bug with Cn_q_circ for UAMod=2
Now displaying a version # for UnsteadyAero module
Cleanup some of the Output handling in UnsteadyAero
Fixed bug where the last two output channels did not have units in UnsteadyAero
Added back sin terms to for y%Cc calculations when UAMod = 1
Added a check in UA_Driver to make sure p%NumOuts is > 0 before trying to write outputs to a file.
sayerhs and others added 20 commits July 25, 2017 08:40
Spack's HDF5 doesn't use a CMake configuration file, so the dependencies on
zlib and libxml2 are set correctly when compiling the `openfastcpp`
executable. The update specifically adds these dependencies to ensure
compilation under both autoconf and CMake builds of HDF5.
projects and solutions have been updated for more configurations: debug,release,single precision, double precision, 32bit and 64bit.
Initial Regression Test System
add check for valid rotation matrix to beamdyn subroutine BD_CrvExtractCrv
fix compiler warnings regarding too many arguments for c print statements
@ghost ghost self-assigned this Aug 29, 2017
Copy link
Contributor

@michaelasprague michaelasprague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove hard-coded version number, e.g., " OpenFAST v8.17.01c-dev-dc586c7*"

Is the following correct? "See the "license.txt" file distributed with this software for details." I don't see any such file. Can we just print license info in the output?

@ghost
Copy link
Author

ghost commented Aug 29, 2017

closed due to incorrect branches used in merge request.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants