Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Rework #579

Merged
merged 5 commits into from
Oct 28, 2020
Merged

Conversation

rafmudaf
Copy link
Collaborator

Complete this sentence
THIS PULL REQUEST IS READY TO MERGE

Feature or improvement description
This is a major overhaul of the existing GitHub Actions infrastructure. It's a shift from running the full pipeline through a Bash script in Docker to leveraging the Workflows and Actions features in GitHub Actions. Some of the primary features are:

  • No tests are run when a branch name begins with "docs/"
  • On failing runs, the test files are posted to the run's Artifacts for further inspection
  • This will work between forks whereas the existing workflow does not
  • New build targets added for tests so that we do not need to compile code that isn't being tested

Related issue, if one exists
None

Impacted areas of the software
GitHub Actions and CMake targets for unit tests and regression tests

Test results, if applicable
https://github.com/rafmudaf/openfast/actions

This avoids requiring to compile the OpenFAST Library when running
the regression tests since that library takes forever to compile.
@rafmudaf rafmudaf changed the base branch from master to dev October 27, 2020 19:18
@rafmudaf rafmudaf self-assigned this Oct 27, 2020
@rafmudaf rafmudaf force-pushed the ghactions/reg_tests branch from 4d83165 to 5f7d395 Compare October 27, 2020 19:36
@rafmudaf rafmudaf changed the title Ghactions/reg tests GitHub Actions Rework Oct 27, 2020
Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much cleaner approach. From my read through, it looks like it should work well (I don't have a good way to test this, but I know @rafmudaf has done extensive testing on it).

@andrew-platt andrew-platt merged commit 260d971 into OpenFAST:dev Oct 28, 2020
@rafmudaf rafmudaf deleted the ghactions/reg_tests branch October 29, 2020 19:21
@rafmudaf rafmudaf mentioned this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants