-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServoDyn Structural control submodule (formerly TMD) #607
Conversation
4a57cf4
to
9d25f46
Compare
01e7080
to
6a162c6
Compare
Matt Lackner's PhD student created this.
Matt Lackner's PhD student created this.
…put file reading and fix segfault
Rearrange some code as needed.
sphinx-html processes files in alphabetical order. So any files with the bibliography contents for a module must be the very last file in _alphabetical_ order. Found out the hard way after 3 hours of trying to figure out why my bibliography for servodyn-stc was broken in readthedocs....
… and descriptions
22343b4
to
d4e6472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the source code changes in detail, but overall this looks good to me. Just a few comments, mostly pertaining to the ServoDyn and StC input files and related documentation:
Can we reference the contribution of Prof. Matt Lackner at UMASS-Amherst in this pull request?
Can the "platform" StC instances be referred to as "substructure" instead in the input file and documentations? E.g., change "NumPtfmStC" to "NumSStC" etc. And in the StC documentation, refer to the rigid platform in ElastoDyn or the flexible substructure in SubDyn (fixed or floating). The term "platform" is OK for floaters, but not fixed-bottom systems. The term "substructure" is more general and industry accepted.
I'm not sure how StC_CMODE or StC_SA_MODE work now or in combination with the future changes to DISCON. Does StC_CMODE = 2 do anything? Presumably StC_SA_MODE is only used when StC_CMODE = 1? (If, so, this could be documented.) Are all StC_SA_MODE options implemented and controlled be the remaining inputs in this section?
I made the change from "platform" to "substructure" this morning. StC_CMODEThe
The semi-active option is currently enabled. StC_SA_MODEThe
|
d4e6472
to
35ae68f
Compare
2808711
to
ea7fea3
Compare
ea7fea3
to
02a4918
Compare
The original baselines for these two cases on macos had been generated using macos 10.14.6 (High Sierra) with gcc-10.2.0, but after upgrading to macos 10.15.7 (Catalina), some of the math libraries in the framework changed. This resulted in minor differences in the some of the matrix solves in subdyn for these two cases which gives small differences in the loads at two nodes (very small when compared to the magnitude of the loads at the foundation. These are the only two cases with multiple cross members, and only cases that showed this problem. This updates so that all cases pass on macos 10.15.7 (Catalina) with gcc-10.2.0 (from homebrew).
d146d0d
to
32bd980
Compare
This pull request is ready to merge
This update includes significant contributions from the following people at the Univeristy of Massachusetts in Amherst.
Feature or improvement description
The TMD module within ServoDyn has been updated and renamed to Structural Control (StC). This module is used to simulate tuned mass dampers attached to a wind turbine. This includes the following updates:
Impacted areas of the software
-Modeling of tuned mass dampers
To complete before PR
Test results, if applicable
Currently no test cases exist for the StC module.