Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Attribute for sc_end in the FAST.Farm Super Controller #749

Merged
merged 2 commits into from
May 11, 2021

Conversation

jjonkman
Copy link
Collaborator

The !DEC$ ATTRIBUTES DLLEXPORT was missing for sc_end and has now been added.

Applies only to the super controller of FAST.Farm, built with Intel Fortran on Windows. This will not effect any of the r-test results.

All this bug does is write unnecessary messages to the screen, e.g., "Using legacy Bladed DLL interface."
The !DEC$ ATTRIBUTES DLLEXPORT was missing for sc_end and has now been added.
@andrew-platt
Copy link
Collaborator

For clarification: the p%UseLegacyInterface = .TRUE. !InputFileData%UseLegacyInterface change prevents an unnecessary warning during initialization. The InputFileData%UseLegacyInterface was never set, so the DLL initialization could try loading the new interface and giving a warning about it (it was fault tolerant of this and would then try the legacy).

@bjonkman
Copy link
Contributor

It looks like InputFileData%UseLegacyInterface=.true. was in the original pull request (line 2203 of ServoDyn.f90 in #373). But that line went missing when the input file parsing was changed to use strings (#607).

@andrew-platt
Copy link
Collaborator

Whoops. That would be my bug then.

@rafmudaf rafmudaf mentioned this pull request May 12, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants