Add snapshots option to cli pull command

[midigofrank]

Short Description

Adds --snapshots option to cli pull command

Related issue

Fixes #729

QA Notes

• openfnx pull {projectId} should work as it was before
• adding --snapshots option appends the snapshots to the query params. i.e ?snapshots[]=1&snapshots[]=2

Checklist before requesting a review

• I have performed a self-review of my code
• I have added unit tests
• Changesets have been added (if there are production code changes)

[midigofrank]

@josephjclark I'm unable to find the tests for cli pull command and so I'm not even sure how to start writing tests for my changes. Do you have some pointers?

[josephjclark]

@midigofrank Ack, you're right. Our testing across deploy and pull has always been extremely poor and it's never been important enough to fix.

We'll test any new CLI commands manually as part of QA on this branch. So no CLI tests needed.

In packages/deploy, could you write some tests against getLightningUrl ? They can go in index.test.ts

[josephjclark]

@midigofrank aside from the typo this looks fine, but I'm curious about the URL

This is a strange format to me:

?snapshots[]=1&snapshots[]=2

What's up with the square brackets?

I suppose this is a lightning design thing, but I wo?snapshots[]=1&snapshots[]=2

I would expect either of the following formats:

?snapshot=1&snapshot=2
?snapshots=1,2

[midigofrank]

Hey @josephjclark, the square braces is a convention for handling array data sent through forms or just get requests.

When phoenix sees that kind of data, it will correctly parse it as an array. This same approach is used to submit nested data. You can see this in action in the workflow editor form.

Here's the input for editing the first job's name:

<input class="" id="workflow_jobs_0_name" name="workflow[jobs][0][name]" type="text" value="Transform data to FHIR standard">

This gets parsed as: {workflow: {jobs: {0: {name: "Transform data to FHIR standard"}}}}

[josephjclark]

Cool, I've never seen that before.

I'll approve once the typo is fixed. I haven't tested this at all. Do you want someone to run QA or shall we just release it? Looks like quite a safe change

[midigofrank]

I see no harm at all, lets just release it.