Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshots to the url for fetching project spec #734

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

midigofrank
Copy link
Contributor

Short Description

This is a follow up to #732
The cli makes 2 API requests when you run openfn pull {projectID} .

This PR adds the provided snapshot ids to the URL for fetching the project spec

Related issue

Fixes #729

Implementation Details

  • I'm a little worried that the logic for building the query params has been duplicated. At the same time, I think it's okay to duplicate it because they are 2 different endpoints and they "could" require different logic.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added unit tests
  • Changesets have been added (if there are production code changes)

@midigofrank midigofrank self-assigned this Jul 17, 2024
@@ -0,0 +1,5 @@
---
'@openfn/cli': minor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably call this a patch actually @midigofrank - it doesn't change the external API. Let's treat it as a fix to the previous.

I'll go ahead and do this now

@josephjclark josephjclark merged commit acceafe into main Jul 17, 2024
6 checks passed
@josephjclark josephjclark deleted the include-snapshot-ids-when-fetching-project-spec branch July 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: add an option to pull that targets given snapshots
2 participants