-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support credentials in deploy package #743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christad92
approved these changes
Aug 13, 2024
3 tasks
@midigofrank , can you resolve the merge conflicts here? i've also requested a review from @stuartc as he's likely to have some opinions 😄 |
midigofrank
force-pushed
the
support-credentials
branch
from
August 14, 2024 11:00
88d7a2f
to
e89d0be
Compare
josephjclark
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested anything but happy with the code.
When you want to release, can you please follow the Release Process steps in the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Support the management of project credentials in via
project.yaml
- works with thesupport-credentials-in-cli-deploy
branch in lightningImplementation Details
pull
, the state is updated with theproject wide credentials
credential key
QA Notes
List any considerations/cases/advice for testing/QA here.
Checklist before requesting a review
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset
from root to bump versionspnpm install
pnpm changeset tag
to generate tagsgit push --tags
Tags may need updating if commits come in after the tags are first generated.