-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage project-credentials via provisioning API #2372
Conversation
project.yaml
2e04743
to
00ed0b2
Compare
when merging this, please merge OpenFn/docs#533 |
project.yaml
@christad92 and @stuartc , this is ready to go. note that the integration tests will not pass until OpenFn/kit#743 is merged and released. (This poses a tricky co-dependency, cc @josephjclark .) Note that the full feature here is represented by:
I'll send the branches and testing instructions to MSF now and we may have feedback on how they want this to work, but the big picture is satisfied and we can now set up a full, running Lightning instance via shell script! git clone msf-openfn-lime-iraq
docker compose blah blah
docker exec -it <BLAH> -- /app/bin/lightning eval Lightning.SetupUtils.setup_user(%{first_name: "Michel", last_name: "B", email: "blah@geneva.msf.org", password: "passwordFromVault"}, "apiTokenFromVault", [%{name: "openmrs", schema: "raw", body: %{"a" => "secret"}}, %{ name: "dhis2", schema: "raw", body: %{“username” => “admin”, "password" => "passwordFromVault"}}])
openfn deploy projectIraq.yaml It's pretty rad 😄 |
…/lightning into support-credentials-in-cli-deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Love it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taylordowns2000 on you to test deletion 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
==========================================
+ Coverage 89.83% 89.85% +0.02%
==========================================
Files 305 305
Lines 10455 10497 +42
==========================================
+ Hits 9392 9432 +40
- Misses 1063 1065 +2 ☔ View full report in Codecov by Sentry. |
Description
project_credentials
via the CLI deploy command.cli deploy
- this is something that we do want to do, but will handle in another issue. (Support project-credential deletion via provisioning controller #2382)Validation steps
Additional notes for the reviewer
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)