Fix tests #195
Merged
Fix tests #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid trimming a leading underscore from a key or tag value when coming up with candidate wiki page titles.
|
Just confirming: this is ready to be merged @1ec5? |
|
Yes, this is ready to go. |
This was referenced Apr 26, 2024
Merged
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 28 failures and several warnings in tests. #145 and #178 didn’t account for the mocked preset tables lacking the presets we wanted to modify, and also didn’t update the tests for finding documentation on the wiki. Similarly, #181 didn’t mock one of the files that iD normally fetches over the network, so the test harness was fetching it over the network and complaining about it.
Fixes OpenHistoricalMap/issues#720 and fixes OpenHistoricalMap/issues#721.