Addresses #722 Configure continuous integration for iD #201
Conversation
…nd tests on any push to any branch.
|
This is not what causes the tests to fail (#195). With this in place we'll learn earlier that tests are failing. |
| @@ -5,9 +5,8 @@ name: build | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ main, develop ] | |||
There was a problem hiding this comment.
I think we should build for both the push and PR triggers.
There was a problem hiding this comment.
An empty push: builds for any branch.
There was a problem hiding this comment.
That’s what I figured too, but the push build isn’t running for this PR for some reason.
There was a problem hiding this comment.
It's run three times: https://github.com/OpenHistoricalMap/iD/actions/workflows/build.yml
| pull_request: | ||
| branches: [ main, develop ] | ||
| branches: [ staging, release ] |
There was a problem hiding this comment.
For what it’s worth, the upstream repository doesn’t even have a main branch. staging would be our analogue to its develop branch. We won’t ever open a PR targeting the release branch, so that part will never run.
There was a problem hiding this comment.
release came up in the discussion about why temaki sprites weren't being committed so I left it in as a reminder to myself to try and understand the upstream flow.
|
I merged this into |
Changing the config so that a push to any branch or a PR to
stagingorreleasekicks off a build.