-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running LSP4iJ continuous integration builds with existing LTI releases #864
Fix running LSP4iJ continuous integration builds with existing LTI releases #864
Conversation
Reference link for Cron job action : https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/9856244732 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaisakhkannan can you attach the link for the latest build and cron job after the changes made?
@anusreelakshmi934 , Link for the build --> https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/9934992707 NOTE: With this latest change (based on the Kochi team's suggestion) Cron Job build will fail on fork cron job builds because
Link For cron job when I added repository as Link For cron job when I don't specify repository as |
Shouldn't the job also run against LTI main? |
@anusreelakshmi934 , If we need to run on the main branch as well, we can add 'main' in the matrix tag. |
21da04e
to
9f956ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
Can you share the cronjob link here @vaisakhkannan ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
a3a29dd
4e38955
to
a3a29dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on seeing this in action through demos and resolution of discussions with the team that I took part in. Great work!
1bb8d42
into
OpenLiberty:lsp4ij-market-0.0.2-integration
Fixes #815
A part of the fix for - #868
Implementation of running LSP4iJ continuous integration builds with existing LTI releases
Currently, the fix is running against the branch
lsp4ij-market-0.0.2-integration
. We can add themain
and other existingLTI release tags
, but those will fail because of themicroshed:lsp4ij
dependency. Once we have an LTI release that uses theredhat:lsp4ij
plugin, we will be able to easily add the version in thetag
specified in the code.