Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running LSP4iJ continuous integration builds with existing LTI releases #864

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4246877
Added code to run builds against our existing LTI releases or branches
vaisakhkannan Jul 9, 2024
a700314
Added required 'refLTITag'
vaisakhkannan Jul 9, 2024
f901025
Removed repository
vaisakhkannan Jul 9, 2024
b1be202
Added 'main' for testing
vaisakhkannan Jul 9, 2024
7877971
Specified repo path to get build success on both cron job and default…
vaisakhkannan Jul 9, 2024
f32bf4b
Added comments and specified repo path
vaisakhkannan Jul 9, 2024
72cf004
Removed added 'push' for testing cron job
vaisakhkannan Jul 9, 2024
43b640d
Update cronJob.yaml
vaisakhkannan Jul 12, 2024
3cc954d
Update cronJob.yaml
vaisakhkannan Jul 12, 2024
2e4e508
Update cronJob.yaml
vaisakhkannan Jul 12, 2024
87c22c4
Update cronJob.yaml
vaisakhkannan Jul 12, 2024
197ea8d
Required given back to false for 'refLTITag'
vaisakhkannan Jul 12, 2024
6bbe8f9
Addressed review comments
vaisakhkannan Jul 12, 2024
011faa4
Specified Correct branch and removed Parameter 'specifyRepo'
vaisakhkannan Jul 15, 2024
118f65e
Update build.yaml
vaisakhkannan Jul 18, 2024
d5e3295
given 'default' value if 'env.REF_LTI_TAG' is empty
vaisakhkannan Jul 19, 2024
a3a29dd
made change to the name of LSP4IJ_BRANCH env variable
vaisakhkannan Jul 23, 2024
538ac38
Simplified the usage of env.REF_LTI_TAG
vaisakhkannan Aug 8, 2024
bb340b5
added code as part of testing
vaisakhkannan Aug 8, 2024
b98e38a
Update cronJob.yaml
vaisakhkannan Aug 8, 2024
dc138fa
Removed the code that was added for testing
vaisakhkannan Aug 8, 2024
4caedf6
cleaned up the code
vaisakhkannan Aug 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ on:
required: true
type: boolean
default: false
refLTITag:
description: 'Reference LTI Tag/Branch'
type: string
required: true
default: main
workflow_dispatch:
inputs:
useLocalPlugin:
Expand All @@ -29,6 +34,11 @@ on:
type: string
required: true
default: main
refLTITag:
description: 'Reference LTI Tag/Branch'
type: string
required: false
default: main
push:
branches: '**'
pull_request:
Expand All @@ -54,7 +64,8 @@ jobs:
env:
USE_LOCAL_PLUGIN: ${{ inputs.useLocalPlugin || false }}
REF_LSP4IJ: ${{ inputs.refLsp4ij }}
LSP4IJ_BRANCH: ${{ inputs.lsp4ijBranch || 'latest' }}
LSP4IJ_BRANCH: ${{ inputs.lsp4ijBranch || 'default' }}
REF_LTI_TAG: ${{ inputs.refLTITag }}
steps:
- name: Configure pagefile
if: contains(matrix.os, 'windows')
Expand All @@ -67,6 +78,7 @@ jobs:
uses: actions/checkout@v3
with:
path: liberty-tools-intellij
ref: ${{ env.REF_LTI_TAG }}
- name: 'Install required integration test software'
working-directory: ./liberty-tools-intellij
run: bash ./src/test/resources/ci/scripts/setup.sh
Expand Down Expand Up @@ -96,7 +108,7 @@ jobs:
if: ${{ runner.os == 'Linux' && !failure() }}
uses: actions/upload-artifact@v4.3.4
with:
name: liberty-tools-intellij-LTI-main-LSP4IJ-${{ env.LSP4IJ_BRANCH }}
name: liberty-tools-intellij-LTI-${{ env.REF_LTI_TAG || 'default' }}-LSP4IJ-${{ env.LSP4IJ_BRANCH }}
path: |
./**/*liberty-tools-intellij*.zip
./**/libs/*liberty-tools-intellij*.jar
Expand Down
13 changes: 11 additions & 2 deletions .github/workflows/cronJob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,21 +94,30 @@ jobs:
strategy:
fail-fast: false
matrix:
# Existing LTI release tags and branches can be added to obtain build results.If the tag array is empty, it will default to 'main'. However, if there is at least one tag or branch in the tag array and you need to run on 'main' as well, make sure to add 'main' to the array.
tag: [ 'lsp4ij-market-0.0.2-integration' ] # Can specify tags or branches such as '24.0.6' and 'main'
aparnamichael marked this conversation as resolved.
Show resolved Hide resolved
aparnamichael marked this conversation as resolved.
Show resolved Hide resolved
pr_details: ${{ fromJson(needs.fetch_all_pull_request_shas.outputs.pr_details) }}
with:
useLocalPlugin: true
refLsp4ij: ${{ matrix.pr_details.sha }}
lsp4ijBranch: PR-${{ matrix.pr_details.number }}
name: Running PR
refLTITag: ${{ matrix.tag }}
name: Run PR

# Run the LTI Tests against lsp4ij main branch
call-build-workflow-for-lsp4ij-main-branch:
uses: ./.github/workflows/build.yaml
strategy:
fail-fast: false
matrix:
# Existing LTI release tags and branches can be added to obtain build results.If the tag array is empty, it will default to 'main'. However, if there is at least one tag or branch in the tag array and you need to run on 'main' as well, make sure to add 'main' to the array.
tag: [ 'lsp4ij-market-0.0.2-integration' ]
vaisakhkannan marked this conversation as resolved.
Show resolved Hide resolved
with:
useLocalPlugin: true
refLsp4ij: main
lsp4ijBranch: main
name: Run LTI tests for Lsp4ij Main branch
refLTITag: ${{ matrix.tag }}
name: Run Lsp4ij Main

# Send slack notification for build results
call-build-workflow-slack-notification:
Expand Down
Loading