JAX-B: Add xmlBinding-4.0 Impl and tests #21863

neuwerk · 2022-07-26T07:58:11Z

This PR does a few things:
1.) It integrates the xmlBinding-4.0 impl into open-liberty
2.) It disables a handful of NoClassDefinitionFoundErrors during the JAXBContext look up, to allow for the case of where a non Default implementation is configured, but not available to the TCCL, and rather than failing prints a warning and falls back to the RI for use.
3.) Expands the com.ibm.ws.jaxb_fat test bucket to more thoroughly test JAXBContext creation for marshalling and unmarshalling, but also tests the above changers outline in number 2 above

neuwerk · 2022-07-26T07:58:20Z

#build

LibbyBot · 2022-07-26T07:59:16Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2022-07-26T07:59:19Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_eC0QMAywEe2vacLbpVXjpQ

Target locations of links might be accessible only to IBM employees.

tevans78 · 2022-07-26T11:22:14Z

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/LibertyJAXBContextTest.java

@@ -0,0 +1,65 @@
+/**


Missing copyright header

tevans78 · 2022-07-26T11:23:20Z

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/LibertyThirdPartyJAXBImplContextTest.java

@@ -0,0 +1,47 @@
+/**


missing header

tevans78

Please fix copyright headers ASAP

neuwerk · 2022-07-26T16:57:41Z

@tevans78 done!

helyarp

Suggested changes

...a.xmlBinding.4.0/resources/io/openliberty/jakarta/xmlbinding/resources/JAXBMessages.nlsprops

neuwerk · 2022-07-27T04:40:40Z

#build

LibbyBot · 2022-07-27T04:40:46Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2022-07-27T04:40:50Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_6KhZIA1dEe2vacLbpVXjpQ

Target locations of links might be accessible only to IBM employees.

neuwerk · 2022-07-27T04:41:29Z

@helyarp changes should be incorporated now! Thank you!

neuwerk · 2022-07-27T04:41:36Z

#build

LibbyBot · 2022-07-27T04:41:41Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2022-07-27T04:41:42Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_B6gjoA1eEe2vacLbpVXjpQ

Target locations of links might be accessible only to IBM employees.

helyarp

Thanks for making the changes

LibbyBot · 2022-07-27T16:02:47Z

The build neuwerk-21863-20220726-2149
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_B6gjoA1eEe2vacLbpVXjpQ
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_B6gjoA1eEe2vacLbpVXjpQ

LibbyBot · 2022-07-27T16:34:59Z

The build neuwerk-21863-20220726-2148
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_6KhZIA1dEe2vacLbpVXjpQ
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_6KhZIA1dEe2vacLbpVXjpQ

posmith · 2022-08-01T19:15:48Z

L2 message review completed

jhanders34

In general I would like to see EE10 only tests to be in a new fat project instead of reusing com.ibm.ws.jaxb_fat. Something like io.openliberty.xmlBinding.4.0.internal_fat.

dev/com.ibm.ws.jaxb_fat/.classpath

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/LibertyJAXBContextTest.java

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/LibertyJAXBTest.java

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/LibertyThirdPartyJAXBImplContextTest.java

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/LibertyJAXBTest.java

dev/io.openliberty.jakarta.xmlBinding.4.0/src/jakarta/xml/bind/ContextFinder.java

dev/io.openliberty.xmlBinding.3.0.internal.tools/bnd.bnd

dev/io.openliberty.xmlBinding.4.0.internal.tools/.classpath

dev/io.openliberty.xmlBinding.4.0.internal.tools/bnd.bnd

neuwerk · 2022-08-04T06:33:23Z

#build

LibbyBot · 2022-08-04T06:33:26Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2022-08-04T06:33:30Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-PDOIBO2Ee2JSL2ccGwYRA

Target locations of links might be accessible only to IBM employees.

neuwerk · 2022-08-04T17:26:26Z

#build

LibbyBot · 2022-08-04T17:26:31Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2022-08-04T17:26:34Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_NHfZthQSEe2JSL2ccGwYRA

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2022-08-04T17:28:38Z

The build neuwerk-21863-20220803-2349
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-PDOIBO2Ee2JSL2ccGwYRA
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_-PDOIBO2Ee2JSL2ccGwYRA

dev/cnf/oss_dependencies.maven

neuwerk · 2022-08-05T03:39:18Z

#build

LibbyBot · 2022-08-05T03:39:21Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2022-08-05T03:39:25Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_0Y8mQBRnEe2JSL2ccGwYRA

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2022-08-05T05:39:34Z

The build neuwerk-21863-20220804-1035
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_NHfZthQSEe2JSL2ccGwYRA
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_NHfZthQSEe2JSL2ccGwYRA

LibbyBot · 2022-08-05T14:21:55Z

The build neuwerk-21863-20220804-2048
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_0Y8mQBRnEe2JSL2ccGwYRA
completed successfully!

jhanders34 · 2022-08-05T22:01:33Z

#libby

tevans78 · 2022-08-09T09:09:45Z

...ty.xmlBinding.4.0.internal_fat/test-applications/jaxbApp/src/jaxb/web/dataobjects/Items.java

+// This file was generated by the JavaTM Architecture for XML Binding(JAXB) Reference Implementation, vIBM 2.2.3-11/28/2011 06:17 AM(foreman)-
+// See <a href="http://java.sun.com/xml/jaxb">http://java.sun.com/xml/jaxb</a>
+// Any modifications to this file will be lost upon recompilation of the source schema.
+// Generated on: 2013.02.07 at 02:15:17 PM CST


This comment can’t be true since this file contains jakarta imports

Good point! I did manually update these, and altered them in other ways so I've amended the commit to add the normal IBM copyright.

tevans78

Approved. One minor issue was with the comments in the ‘jaxb.web.dataobjects’. They say that the classes were auto generated in 2013, which can’t be true since they include jakarta imports.

neuwerk · 2022-08-09T14:44:55Z

#libby

LibbyBot · 2022-08-09T14:45:03Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

6 product code files were changed.
Please describe in a separate comment how you tested your changes.
8 infrastructure code files were changed.
34 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).

LibbyBot added the CLA Signed label Jul 26, 2022

tevans78 reviewed Jul 26, 2022

View reviewed changes

tevans78 requested changes Jul 26, 2022

View reviewed changes

helyarp reviewed Jul 26, 2022

View reviewed changes

helyarp added the ID waiting on development label Jul 26, 2022

helyarp reviewed Jul 27, 2022

View reviewed changes

helyarp added ID reviewed and removed ID waiting on development labels Jul 27, 2022

posmith added the L2 Reviewed label Aug 1, 2022

jhanders34 requested changes Aug 3, 2022

View reviewed changes

neuwerk force-pushed the xmlBinding4Impl branch 2 times, most recently from e65b14a to cd2a8c9 Compare August 4, 2022 06:32

neuwerk added 2 commits August 4, 2022 12:06

Initial xmlBinding-4.0 impl changes

345d64a

Refactor jaxb_fat to xmlbinding.4.0_fat and other code review changes

d4260eb

neuwerk force-pushed the xmlBinding4Impl branch from 228684f to 1bd1961 Compare August 4, 2022 17:24

jhanders34 reviewed Aug 4, 2022

View reviewed changes

dev/cnf/oss_dependencies.maven Outdated Show resolved Hide resolved

neuwerk force-pushed the xmlBinding4Impl branch from 1bd1961 to fe901b4 Compare August 5, 2022 03:38

jhanders34 approved these changes Aug 5, 2022

View reviewed changes

jhanders34 requested a review from tevans78 August 5, 2022 22:00

tevans78 reviewed Aug 9, 2022

View reviewed changes

tevans78 approved these changes Aug 9, 2022

View reviewed changes

Remove xmlBinding-4.0 non-RI impl warnings for Beta

ea233e5

neuwerk force-pushed the xmlBinding4Impl branch from fe901b4 to ea233e5 Compare August 9, 2022 14:37

neuwerk merged commit 7af65c6 into OpenLiberty:integration Aug 9, 2022

neuwerk mentioned this pull request Aug 10, 2022

Revert "JAX-B: Add xmlBinding-4.0 Impl and tests" #22052

Merged

LibbyBot mentioned this pull request Aug 10, 2022

Re-introduce change reverted from 21863 #22053

Open

neuwerk mentioned this pull request Aug 10, 2022

Revert 22052 revert 21863 xml binding4 impl #22056

Merged

JAX-B: Add xmlBinding-4.0 Impl and tests #21863

JAX-B: Add xmlBinding-4.0 Impl and tests #21863

Conversation

neuwerk commented Jul 26, 2022 • edited Loading

neuwerk commented Jul 26, 2022

LibbyBot commented Jul 26, 2022

LibbyBot commented Jul 26, 2022

tevans78 Jul 26, 2022

Choose a reason for hiding this comment

tevans78 Jul 26, 2022

Choose a reason for hiding this comment

tevans78 left a comment

Choose a reason for hiding this comment

neuwerk commented Jul 26, 2022

helyarp left a comment

Choose a reason for hiding this comment

neuwerk commented Jul 27, 2022

LibbyBot commented Jul 27, 2022

LibbyBot commented Jul 27, 2022

neuwerk commented Jul 27, 2022

neuwerk commented Jul 27, 2022

LibbyBot commented Jul 27, 2022

LibbyBot commented Jul 27, 2022

helyarp left a comment

Choose a reason for hiding this comment

LibbyBot commented Jul 27, 2022

LibbyBot commented Jul 27, 2022

posmith commented Aug 1, 2022

jhanders34 left a comment

Choose a reason for hiding this comment

neuwerk commented Aug 4, 2022

LibbyBot commented Aug 4, 2022

LibbyBot commented Aug 4, 2022

neuwerk commented Aug 4, 2022

LibbyBot commented Aug 4, 2022

LibbyBot commented Aug 4, 2022

LibbyBot commented Aug 4, 2022

neuwerk commented Aug 5, 2022

LibbyBot commented Aug 5, 2022

LibbyBot commented Aug 5, 2022

LibbyBot commented Aug 5, 2022

LibbyBot commented Aug 5, 2022

jhanders34 commented Aug 5, 2022

tevans78 Aug 9, 2022

Choose a reason for hiding this comment

neuwerk Aug 9, 2022

Choose a reason for hiding this comment

tevans78 left a comment

Choose a reason for hiding this comment

neuwerk commented Aug 9, 2022

LibbyBot commented Aug 9, 2022

Code analysis and actions

neuwerk commented Jul 26, 2022 •

edited

Loading