Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd fips1403 #30324

Draft
wants to merge 109 commits into
base: integration
Choose a base branch
from
Draft

Jd fips1403 #30324

wants to merge 109 commits into from

Conversation

jacobwdv
Copy link
Contributor

@jacobwdv jacobwdv commented Dec 3, 2024

################################################################################################

Delete this section and fill in the remaining info from the template

ATTENTION, READ THIS: Updated July 2024

Read and understand this completely, then delete the static part of the template.

If a reviewer or merger sees this template, they should fail the review or merge.

If this code change is fixing a user-visible bug in previously released code, it MUST
have an associated issue mentioned in the PR text or description.

  • That Issue also MUST be labelled “release bug”

    This directs automation to scrape this fix for inclusion in the next release's
    list of bugs fixed.

  • The linkage between PR and Issue should use the Fixes #... syntax rather than a manual
    link via the Development widget.

Otherwise, a link to an issue or specific issue labels are optional.

For full details, please see this wiki page: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions
################################################################################################

@jacobwdv
Copy link
Contributor Author

jacobwdv commented Dec 3, 2024

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

@LibbyBot
Copy link

LibbyBot commented Dec 3, 2024

Please code review feature-related files, @OpenLiberty/delivery-approvers

1 similar comment
@LibbyBot
Copy link

LibbyBot commented Dec 3, 2024

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Dec 3, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_0xr5YrE4Ee-Q24Sd2QdBoQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Dec 3, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 71 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 8 infrastructure code files were changed.

  • 6 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 253 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 16 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops

  • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

  • 16 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops

  • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

Copy link

@jantley-ibm jantley-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few ID suggestions provided. I will add the ID reviewed tag when we agree on changes. Let me know if you have questions or concerns. Thanks!

CRYPTO_INSECURE.useraction=Use the suggested secure algorithm.

CRYPTO_INSECURE_REPLACED=CWWKS5901W: The {0} configuration element specifies the {1} insecure cryptographic algorithm. The {2} secure algorithm is used instead.
CRYPTO_INSECURE_REPLACED.explanation=The insecure cryptographic algorithm was replaced with the secure algorithm.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest instead:
CRYPTO_INSECURE_REPLACED.explanation=The configuration is updated to use a secure cryptographic algorithm instead of the insecure one that was originally specified.

(I am trying to be more explicit about what is actually happening; if I have misunderstood the process, please let me know.)

CRYPTO_INSECURE_REPLACED.explanation=The insecure cryptographic algorithm was replaced with the secure algorithm.
CRYPTO_INSECURE_REPLACED.useraction=No action is required.

CRYPTO_INSECURE_PROVIDER=CWWKS5902W: The {0} configuration element uses the {1} insecure cryptographic algorithm. Consider replacing the configuration with a different provider if security is a concern.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change:
Consider replacing the configuration with a different provider if security is a concern.
to
If security is a concern, consider replacing the configuration with a different provider.


CRYPTO_INSECURE_PROVIDER=CWWKS5902W: The {0} configuration element uses the {1} insecure cryptographic algorithm. Consider replacing the configuration with a different provider if security is a concern.
CRYPTO_INSECURE_PROVIDER.explanation=The algorithm is no longer considered cryptographically secure.
CRYPTO_INSECURE_PROVIDER.useraction=Consider replacing the configuration with a different provider if security is a concern.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change:
Consider replacing the configuration with a different provider if security is a concern.
to
If security is a concern, consider replacing the configuration with a different provider.

@jacobwdv jacobwdv force-pushed the JD_FIPS1403 branch 4 times, most recently from 1dfb767 to 1991890 Compare December 5, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants