-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jd fips1403 #30324
base: integration
Are you sure you want to change the base?
Jd fips1403 #30324
Conversation
Rename generate3DESKey method to generateSharedKey
add common crypto to ssl feature
Undo changes for LogPolice
Deleting ltpa.keys when FIPS keys not found
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) |
Please code review feature-related files, @OpenLiberty/delivery-approvers |
1 similar comment
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_0xr5YrE4Ee-Q24Sd2QdBoQ Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few ID suggestions provided. I will add the ID reviewed tag when we agree on changes. Let me know if you have questions or concerns. Thanks!
CRYPTO_INSECURE.useraction=Use the suggested secure algorithm. | ||
|
||
CRYPTO_INSECURE_REPLACED=CWWKS5901W: The {0} configuration element specifies the {1} insecure cryptographic algorithm. The {2} secure algorithm is used instead. | ||
CRYPTO_INSECURE_REPLACED.explanation=The insecure cryptographic algorithm was replaced with the secure algorithm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest instead:
CRYPTO_INSECURE_REPLACED.explanation=The configuration is updated to use a secure cryptographic algorithm instead of the insecure one that was originally specified.
(I am trying to be more explicit about what is actually happening; if I have misunderstood the process, please let me know.)
CRYPTO_INSECURE_REPLACED.explanation=The insecure cryptographic algorithm was replaced with the secure algorithm. | ||
CRYPTO_INSECURE_REPLACED.useraction=No action is required. | ||
|
||
CRYPTO_INSECURE_PROVIDER=CWWKS5902W: The {0} configuration element uses the {1} insecure cryptographic algorithm. Consider replacing the configuration with a different provider if security is a concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change:
Consider replacing the configuration with a different provider if security is a concern.
to
If security is a concern, consider replacing the configuration with a different provider.
|
||
CRYPTO_INSECURE_PROVIDER=CWWKS5902W: The {0} configuration element uses the {1} insecure cryptographic algorithm. Consider replacing the configuration with a different provider if security is a concern. | ||
CRYPTO_INSECURE_PROVIDER.explanation=The algorithm is no longer considered cryptographically secure. | ||
CRYPTO_INSECURE_PROVIDER.useraction=Consider replacing the configuration with a different provider if security is a concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change:
Consider replacing the configuration with a different provider if security is a concern.
to
If security is a concern, consider replacing the configuration with a different provider.
1dfb767
to
1991890
Compare
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).################################################################################################
Delete this section and fill in the remaining info from the template
ATTENTION, READ THIS: Updated July 2024
Read and understand this completely, then delete the static part of the template.
If a reviewer or merger sees this template, they should fail the review or merge.
If this code change is fixing a user-visible bug in previously released code, it MUST
have an associated issue mentioned in the PR text or description.
That Issue also MUST be labelled “release bug”
This directs automation to scrape this fix for inclusion in the next release's
list of bugs fixed.
The linkage between PR and Issue should use the
Fixes #...
syntax rather than a manuallink via the Development widget.
Otherwise, a link to an issue or specific issue labels are optional.
For full details, please see this wiki page: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions
################################################################################################