This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Add compression option to HttpTransport #318
Merged
mobuchowski
merged 1 commit into
OpenLineage:main
from
dolfinus:feature/transport-compression
Apr 18, 2024
Merged
Add compression option to HttpTransport #318
mobuchowski
merged 1 commit into
OpenLineage:main
from
dolfinus:feature/transport-compression
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mellifluous-eclair-326dcd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dolfinus
force-pushed
the
feature/transport-compression
branch
from
April 15, 2024 09:27
20cf4a0
to
e50bbb0
Compare
kacpermuda
approved these changes
Apr 15, 2024
kacpermuda
suggested changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could you please add somewhere in the description that this option is only available since version 1.13 ?
dolfinus
changed the title
Add compression option to HttpTtansport
Add compression option to HttpTransport
Apr 15, 2024
pawel-big-lebowski
approved these changes
Apr 16, 2024
Ok, I'll push a commit later |
dolfinus
force-pushed
the
feature/transport-compression
branch
from
April 17, 2024 15:19
e50bbb0
to
f9ec8f1
Compare
Added a note that this option was added since 1.13.0 |
dolfinus
force-pushed
the
feature/transport-compression
branch
from
April 17, 2024 15:45
f9ec8f1
to
bb7632a
Compare
kacpermuda
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's wait for the 1.13 release and merge this.
dolfinus
force-pushed
the
feature/transport-compression
branch
from
April 18, 2024 11:46
bb7632a
to
26c457d
Compare
Signed-off-by: Мартынов Максим Сергеевич <msmarty5@mts.ru>
dolfinus
force-pushed
the
feature/transport-compression
branch
from
April 18, 2024 12:10
26c457d
to
582e011
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for new
HttpTransport
config optioncompression
, introduced in OpenLineage/OpenLineage#2595.Probably should not be merged before OpenLineage 1.13.0 release.