Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Add compression option to HttpTransport #318

Merged

Conversation

dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Apr 15, 2024

Documentation for new HttpTransport config option compression, introduced in OpenLineage/OpenLineage#2595.

Probably should not be merged before OpenLineage 1.13.0 release.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for mellifluous-eclair-326dcd ready!

Name Link
🔨 Latest commit 582e011
🔍 Latest deploy log https://app.netlify.com/sites/mellifluous-eclair-326dcd/deploys/66210d9a68763900087dfe02
😎 Deploy Preview https://deploy-preview-318--mellifluous-eclair-326dcd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dolfinus dolfinus force-pushed the feature/transport-compression branch from 20cf4a0 to e50bbb0 Compare April 15, 2024 09:27
Copy link
Contributor

@kacpermuda kacpermuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you please add somewhere in the description that this option is only available since version 1.13 ?

@dolfinus dolfinus changed the title Add compression option to HttpTtansport Add compression option to HttpTransport Apr 15, 2024
@dolfinus
Copy link
Contributor Author

Actually, could you please add somewhere in the description that this option is only available since version 1.13 ?

Ok, I'll push a commit later

@dolfinus dolfinus force-pushed the feature/transport-compression branch from e50bbb0 to f9ec8f1 Compare April 17, 2024 15:19
@dolfinus
Copy link
Contributor Author

Added a note that this option was added since 1.13.0

@dolfinus dolfinus requested a review from kacpermuda April 17, 2024 15:23
@dolfinus dolfinus force-pushed the feature/transport-compression branch from f9ec8f1 to bb7632a Compare April 17, 2024 15:45
Copy link
Contributor

@kacpermuda kacpermuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the 1.13 release and merge this.

@dolfinus dolfinus force-pushed the feature/transport-compression branch from bb7632a to 26c457d Compare April 18, 2024 11:46
Signed-off-by: Мартынов Максим Сергеевич <msmarty5@mts.ru>
@dolfinus dolfinus force-pushed the feature/transport-compression branch from 26c457d to 582e011 Compare April 18, 2024 12:10
@mobuchowski mobuchowski merged commit e336cbb into OpenLineage:main Apr 18, 2024
6 checks passed
@dolfinus dolfinus deleted the feature/transport-compression branch April 18, 2024 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants