fix(ci): Move the build parameter BASE_IMAGE_TAG at the beginning of the file. #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he file. Signed-off-by: 我怎么就不是一只猫呢? <26274059+dezhishen@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Docker build issue by moving the BASE_IMAGE_TAG argument declaration to the beginning of the Dockerfile. The change ensures that the build parameter is available before it's referenced in the FROM instruction.
Key changes:
- Relocates the
ARG BASE_IMAGE_TAG=basedeclaration and its comment from after the builder stage to the very beginning of the Dockerfile
|
|
||
| ### Default image is base. You can add other support by modifying BASE_IMAGE_TAG. The following parameters are supported: base (default), aria2, ffmpeg, aio | ||
| ARG BASE_IMAGE_TAG=base | ||
|
|
There was a problem hiding this comment.
The ARG BASE_IMAGE_TAG should be declared immediately before this FROM instruction, not at the beginning of the file. In Docker, ARG variables declared before the first FROM are only available in FROM instructions, but not in subsequent build stages. If BASE_IMAGE_TAG needs to be used elsewhere in the Dockerfile after this FROM instruction, it should be redeclared in that stage.
Suggested change
| ARG BASE_IMAGE_TAG=base |
Member
Author
|
duplicati with #1036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the build parameter BASE_IMAGE_TAG at the beginning of the file.
If not, docker build cannot be run.