Skip to content

fix(ci): Move the build parameter BASE_IMAGE_TAG at the beginning of the file. #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dezhishen wants to merge 1 commit into from
Closed

fix(ci): Move the build parameter BASE_IMAGE_TAG at the beginning of the file. #1035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
### Default image is base. You can add other support by modifying BASE_IMAGE_TAG. The following parameters are supported: base (default), aria2, ffmpeg, aio
ARG BASE_IMAGE_TAG=base
FROM alpine:edge AS builder
LABEL stage=go-builder
WORKDIR /app/
Expand All @@ -7,8 +9,7 @@ RUN go mod download
COPY ./ ./
RUN bash build.sh release docker

### Default image is base. You can add other support by modifying BASE_IMAGE_TAG. The following parameters are supported: base (default), aria2, ffmpeg, aio
ARG BASE_IMAGE_TAG=base

Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARG BASE_IMAGE_TAG should be declared immediately before this FROM instruction, not at the beginning of the file. In Docker, ARG variables declared before the first FROM are only available in FROM instructions, but not in subsequent build stages. If BASE_IMAGE_TAG needs to be used elsewhere in the Dockerfile after this FROM instruction, it should be redeclared in that stage.

Suggested change
ARG BASE_IMAGE_TAG=base

Copilot uses AI. Check for mistakes.
FROM openlistteam/openlist-base-image:${BASE_IMAGE_TAG}

ARG INSTALL_FFMPEG=false
Expand Down