-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(archive): support non-overwrite decompress #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(archive): support non-overwrite decompress #1701
Conversation
|
@KirCute, thanks for fixing the problems with part files that have a dot (fix.lock.part1.rar) in their file name. But now that I got time to test it, there's a new problem, maybe because of the regex? It will fail with another part files in the same folder:Test.part1.rar Work.part1.rar File.part1.rar It will work with only part files of one archive in the folder:Test.part1.rar You will need to move/have them in individual folders in order to open or uncompress said files; before, it worked just fine. Another thing, sometimes when uncompressing or streaming zip files, memory could double or more than the zip's original size. So it makes it impossible to uncompress files bigger than the actual RAM of the systems, it's strange because zip support random reads. And sorry, mods. Next time I will probably write a issue ticket. I'm used to write this kind of short problem on PR's. |
I noticed that the upstream library |
|
Edit: It was introduced with #1599; that's why I mentioned that it used to work before (I forgot to tag the PR, sorry!). After a bit more testing, it looks like it opens/uncompresses the last part1.rar file in the folder correctly. |
That's really strange. alexmullins/zip#22 seems to work fine for me. I'll test it out separately with files compressed using different operating systems and different archiving tools later. |
|
Right, zip without password works well, before and after the PR #1599 but zip with password still have the memory overflow issue for me. |
Description / 描述
为解压添加“覆盖现有文件”选项
前端:OpenListTeam/OpenList-Frontend#285
Motivation and Context / 背景
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。