Refinement update #379
Merged
Refinement update #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anscription refinement works now
Kenneth-T-Moore
requested changes
Sep 9, 2020
| self.declare_partials(of='x0_dot', wrt='x4', rows=r, cols=c, val=0.0) | ||
| self.declare_partials(of='x0_dot', wrt='x5', rows=r, cols=c, val=0.0) | ||
| self.declare_partials(of='x0_dot', wrt='u0', rows=r, cols=c, val=0.0) | ||
| self.declare_partials(of='x0_dot', wrt='u1', rows=r, cols=c, val=0.0) |
There was a problem hiding this comment.
For derivatives that are 0.0, it is more efficient to just not declare them at all.
There was a problem hiding this comment.
Fixed that but why is that the case? Is it a coloring issue?
There was a problem hiding this comment.
When you define it, it creates an entry in the jacobian dictionary that is an r x c arrary of zeros, and it performs a matrix vector product when derivatives are computed because it sees 0,0 as just another number that needs to be multiplied. If you don't declare it, then no entry is even created for it, so it does nothing for that input/output pair.
There was a problem hiding this comment.
Makes sense. Thanks!
Kenneth-T-Moore
approved these changes
Sep 9, 2020
robfalck
reviewed
Sep 9, 2020
robfalck
requested changes
Sep 10, 2020
…functions to write error and refinement. Also made hp-method default refinement scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added hp refinement based on "Adaptive mesh refinement method for optimal control using non-smoothness detection and mesh size reduction" by Liu, Hager, and Rao as new refinement scheme.
New scheme allows for detection of where the problem is non-smooth and splits segments rather than simply raise order.
This algorithm is also more efficient in that it also eliminates unnecessary segments and reduces segment order in each iteration so re-solving the problem is less expensive.
Related Issues
Status
Backwards incompatibilities
None
New Dependencies
None