Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker scripts #33

Merged

Conversation

velomatt
Copy link
Contributor

@velomatt velomatt commented May 5, 2023

  • Support GitLab CI vars
  • Support local MinIO endpoint-url

* Support GitLab CI vars
* Support local MinIO endpoint-url
@velomatt velomatt requested a review from a team as a code owner May 5, 2023 01:04
@velomatt velomatt requested a review from snubatreus May 11, 2023 22:41
@velomatt
Copy link
Contributor Author

This is already tested and integrated into the Docker images (both local + Codebuild).

Copy link
Contributor

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@velomatt velomatt merged commit d6cdc2d into master May 11, 2023
@velomatt velomatt deleted the update-build-scripts-to-support-endpoint-url-with-aws-cli branch May 11, 2023 22:48
velomatt added a commit that referenced this pull request May 11, 2023
* Update Docker scripts

* Support GitLab CI vars
* Support local MinIO endpoint-url

* update branch var for gitlab
velomatt added a commit that referenced this pull request May 11, 2023
* Update Docker scripts

* Support GitLab CI vars
* Support local MinIO endpoint-url

* update branch var for gitlab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants