Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker scripts (#33) #35

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

velomatt
Copy link
Contributor

  • Update Docker scripts

  • Support GitLab CI vars

  • Support local MinIO endpoint-url

  • update branch var for gitlab

* Update Docker scripts

* Support GitLab CI vars
* Support local MinIO endpoint-url

* update branch var for gitlab
@velomatt velomatt requested a review from a team as a code owner May 11, 2023 23:01
@velomatt velomatt requested a review from snubatreus May 11, 2023 23:01
@velomatt
Copy link
Contributor Author

Cherry-picked from master. Like the other PR, this has already been tested and integrated into tagged docker images both on Codebuild and local registries.

Copy link
Contributor

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, reviewed for master and approved now approving the same for the stable workflow.

@velomatt velomatt merged commit 803447e into stable/v1.0 May 11, 2023
@velomatt velomatt deleted the Update-Docker-scripts-stable branch May 11, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants