Changing logic to return payload as json in the case of any exception depending on received bytes #20
Conversation
… depending on recevied bytes
| except socket.error as e: | ||
| self.logger.error(f"ClientSocket SocketError: {e}") | ||
| raise socket.error(f"ClientSocket SocketError: {e}") |
There was a problem hiding this comment.
if we are removing all the raise exceptions, then why don't we consolidate all these exceptions into a single one and just log the error
There was a problem hiding this comment.
we could potentially do that, only downside is that we would lose how long a socket timeout took. If you think it is worth it to simplify the code, then I can go ahead and do that.
There was a problem hiding this comment.
Except socket.timeout, you can bundle rest of the exceptions to a generic exception unless it has some value.
There was a problem hiding this comment.
sounds good, thank you
| except ValueError as e: | ||
| raise ValueError(f"ServerSocket: ValueError - {e}") |
There was a problem hiding this comment.
the top comment applies here as well
There was a problem hiding this comment.
responded to comment above
…nd ServerSocket classes
|
Kudos, SonarCloud Quality Gate passed! |
grandsuri
deleted the
19-datamover-all-recv_json-socket-exceptions-must-handle-returning-response-payload-upon-exception
branch
tested on 4 node vm cluster successfully.