Prevent duplicate entry when updating salesrule_coupon_usage (#1117)

* remove $timesUsed > 0 check to prevent duplicate entry * Prevent $timesUsed from going less than 0
OpenMage · Aug 21, 2020 · 1b97c6f · 1b97c6f
1 parent 6dd4989
commit 1b97c6f
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php b/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php
@@ -61,17 +61,20 @@ public function updateCustomerCouponTimesUsed($customerId, $couponId, $decrement
 
         $timesUsed = $read->fetchOne($select, array(':coupon_id' => $couponId, ':customer_id' => $customerId));
 
-        if ($timesUsed !== false && $timesUsed > 0) {
-            $this->_getWriteAdapter()->update(
-                $this->getMainTable(),
-                array(
-                    'times_used' => $timesUsed + ($decrement ? -1 : 1)
-                ),
-                array(
-                    'coupon_id = ?' => $couponId,
-                    'customer_id = ?' => $customerId,
-                )
-            );
+        if ($timesUsed !== false) {
+            $timesUsed += ($decrement ? -1 : 1);
+            if($timesUsed >= 0) {
+                $this->_getWriteAdapter()->update(
+                    $this->getMainTable(),
+                    array(
+                        'times_used' => $timesUsed
+                    ),
+                    array(
+                        'coupon_id = ?' => $couponId,
+                        'customer_id = ?' => $customerId,
+                    )
+                );
+            }
         } else {
             $this->_getWriteAdapter()->insert(
                 $this->getMainTable(),