Prevent duplicate entry when updating salesrule_coupon_usage #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrieger85
previously requested changes
Jul 23, 2020
|
I haven't had a chance to look at this closely but is it related to #1031 which has already been merged? /cc @mattdavenport |
Yes it is, but #1031 caused some issues, especially #1116.
|
sreichel
approved these changes
Aug 19, 2020
colinmollenhour
approved these changes
Aug 21, 2020
colinmollenhour
dismissed
kkrieger85’s stale review
The new code has a second if clause that would addresses the concern.
colinmollenhour
pushed a commit
that referenced
this pull request
Aug 21, 2020
* remove $timesUsed > 0 check to prevent duplicate entry * Prevent $timesUsed from going less than 0
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
* Remove $timesUsed > 0 check to prevent duplicate entry * Prevent $timesUsed from going less than 0 refs: OpenMage#1031
3 tasks
sreichel
added a commit
that referenced
this pull request
Mar 11, 2021
#1302) * bump version * Fix _addUrlRewrite() ignoring collection store scope. (#510) While Mage_Catalog_Model_Resource_Product_Collection::addUrlRewrite() does respect any set storeId on the collection it's helper that does the actual work is hard-coded to the current active store. * Add doc comments to image related classes (#1146) * Prevent duplicate entry when updating salesrule_coupon_usage (#1117) * remove $timesUsed > 0 check to prevent duplicate entry * Prevent $timesUsed from going less than 0 * Fix a bug where media upload via API are not possible anymore: #1178 * revert unwanted changes * Update lib/Varien/Io/File.php Co-authored-by: Flyingmana <flyingmana@googlemail.com> Co-authored-by: Colin Mollenhour <colin@mollenhour.com> Co-authored-by: Erik Dannenberg <ed@reshape.de> Co-authored-by: Tymoteusz Motylewski <t.motylewski@gmail.com> Co-authored-by: Dean Williams <me@deanwilliams.org> Co-authored-by: sv3n <github-sr@hotmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
If you cancel a customer order with a promo code and try to place an order with the same promo code it fails because of an Integrity constraint violation: 1062 Duplicate entry on salesrule_coupon_usage since times_used goes to 0 when the order is canceled. I removed the check for $timesUsed > 0 so that it will run as an update instead of an insert.
Related Pull Requests
#1031
Fixed Issues (if relevant)
Manual testing scenarios (*)