Add "Times used" indicator field to promo rule quote grid

[spinsch]

Description (*)

When I use a single coupon code without the generator, there is no indicator to check how many times the coupon has been used.
And when i cancel an order the "times_used" field from the "salesrule" table was not decremented.
This PR will show the "times_used" field in the promo rule quote grid and fixes the decrementing while cancel an order.

Manual testing scenarios (*)

1. Goto Backend > Promotions > Shopping Cart Price Rules > Add New Rule
2. Create the new Rule with the "Specific Coupon"-Option and set the Coupon Code manually (without the generator)
3. Trigger the Rule
4. Goto Backend > Promotions > Shopping Cart Price Rules and check the "Times used" field.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[m-overlund]

When i filter by times used i'm getting an error report: where clause is ambigious

Integrity constraint violation: 1052 Column 'times_used' in where clause is ambiguous, query was: SELECT COUNT(*) FROM `salesrule` AS `main_table`
 LEFT JOIN `salesrule_coupon` AS `rule_coupons` ON main_table.rule_id = rule_coupons.rule_id AND rule_coupons.is_primary = 1 WHERE (`times_used` >= '1')

Also there seems to be discrepancies between times used in the grid, and times used under Manage Coupon Codes for auto generation rules.
Some times the grid says times used is 1, while Manage Coupon Codes for that rule, says the (single) coupon code is not used.

[spinsch]

Hmm interesting, maybe this is the reason why this field wasn't yet in the main grid. i will fix this asap.
thank you

[m-overlund]

Fixed my sorting issues.

Still not sure why times used sometimes don't match, when coupon code is autogenerated, though.

EDIT:
It seem's like the times_used on Grid is 1 higher than it actually should be - in 95% of my cases.
For autogenerated coupon codes, that is.

[spinsch]

With the latest version on my dev i can only trigger the wrong "times_used" counter from "salesrule" table when i cancel the order.
Last year there were a few pr's that fixed this problem with counting (#1031 and #1117 ).
The counting problem was resolved on my production shop after this two pull requests was merged and live.

[fballiano]

With the latest version on my dev i can only trigger the wrong "times_used" counter from "salesrule" table when i cancel the order. Last year there were a few pr's that fixed this problem with counting (#1031 and #1117 ). The counting problem was resolved on my production shop after this two pull requests was merged and live.

@spinsch if it's resolve do we still need this PR? thank you!

[spinsch]

@fballiano this pr should actually only insert a column in the table with the value of "times_used" so that you can see how many times the rule was applied and is to be considered as a feature.

the discussed problem after that refers to the wrong counting of the counter which appeared by the way. if i merge my pr with the other two, then everything had worked as desired for me.

[fballiano]

ok tested and working, if payment is canceled the salesrule table wasn't updated, with the patch it works

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 2740724. ± Comparison against base commit 7afc8a1.